Ensure not to delete all cache on post update #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/Automattic/wp-super-cache/issues/169 On post update wp_cache_post_edit() does the test on $wp_cache_clear_on_post_edit to decide to clear all cache or not, but when it calls wp_cache_post_change() this function can override that setting, so I added the test there too. ps: sorry this is my first PR ever, I hope I got the procedure right.
Ensure not to delete all cache on post update
|
Thanks for the PR. It was the wrong code, but in the right area. Check out #175 which fixes the problem described in #169. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Automattic/wp-super-cache/issues/169
On post update
wp_cache_post_edit()does the test on$wp_cache_clear_on_post_editto decide to clear all cache or not, but when it callswp_cache_post_change()this function can override that setting, so I added the test there too.ps: sorry this is my first PR ever, I hope I got the procedure right.