Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain management: Take users to account level purchase page instead of site level page when they click on "Delete" or "Payment details" button #99217

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

m1r0
Copy link
Member

@m1r0 m1r0 commented Feb 3, 2025

Resolves #99004

Proposed Changes

  • Update the "Payment details" link to point to the account level purchase page.
  • When deleting a domain and the purchase needs to be canceled, redirect the user to the account level cancel purchase page.

Why are these changes being made?

  • This is part of the domain management revamp project.

Testing Instructions

	if ( isRemovable( purchase ) ) {
		return (
			<DomainInfoCard
				type="custom"
				title={ title }
				description={ getDescription() }
				cta={ removePurchaseRenderedComponent }
			/>
		);
	}

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@m1r0 m1r0 self-assigned this Feb 3, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~100 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
hosting       +271 B  (+0.0%)     +100 B  (+0.0%)
domains       +271 B  (+0.0%)     +100 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@m1r0 m1r0 changed the title Take users to account level page instead of site level page when they click on "Delete" or "Payment details" button Domain management: Take users to account level purchase page instead of site level page when they click on "Delete" or "Payment details" button Feb 3, 2025
@m1r0 m1r0 marked this pull request as ready for review February 3, 2025 16:38
@m1r0 m1r0 requested a review from a team February 3, 2025 16:38
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 3, 2025
Copy link
Member

@merkushin merkushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Payment details link works as expected.

But couldn't test the Delete link because I see a modal.
If I comment out code as you described, I don't see neither a button with modal nor a Delete link.

@merkushin
Copy link
Member

I think I also need to comment the next block:

	if ( ! isCancelable( purchase ) ) {
		return null;
	}

Copy link
Member

@merkushin merkushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both links refer to expected destinations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
3 participants