Editor: minor trash pickup to make autoSave dialog logic more legible #9886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmyc
added
[Feature] Post/Page Editor
timmyc
force-pushed
the
update/editor/trash-pickup
branch
from
a457a86 to
e1ec698
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #9833 - the code trail led me to
post-editor.jsx. MuchTODOin this file, but the particular area I was looking at had a longifstatement that was begging to be simplified with aget- so in an effort to pickup trash daily, here is a very small PR.Changes Made
Updated the conditional logic that determines if
autosavedata exists to uselodash#get(). And for good measure removed olddebugstatements.To Test
Ideally - get a published post to have some autosave data. To do so, open a published post in the editor, make some changes and wait for the autosave to kick in.