Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkout: Fix non-standard property in Apple Pay tracks event #8850

Merged
merged 1 commit into from
Oct 19, 2016
Merged

Checkout: Fix non-standard property in Apple Pay tracks event #8850

merged 1 commit into from
Oct 19, 2016

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Oct 19, 2016 •
edited
Loading

Follow up for #8641.

Property names should also be lowercase and use underscores instead of dashes, but do not need to be prefixed by the service name because the event they are tied to already provides that information. Property names with leading underscores are reserved for special properties so you should always start your property names with a letter.

calypso_apple_pay_status is beeing rejected at the moment by Tracks Live View tool. This PR changes property name to align it with conventions used.

/cc @scruffian @Automattic/sdev-feed

@gziolo gziolo added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Checkout The checkout screen and process for purchases made on WordPress.com. labels Oct 19, 2016
@gziolo gziolo self-assigned this Oct 19, 2016
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=fix/apple-pay-event-property-name

@scruffian
Copy link
Member

LGTM 👍

@scruffian scruffian added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 19, 2016
@gziolo gziolo merged commit 6a78f94 into master Oct 19, 2016
@gziolo gziolo deleted the fix/apple-pay-event-property-name branch October 19, 2016 10:38
@snyk-bot snyk-bot mentioned this pull request Mar 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 30, 2021
Open
@snyk-bot snyk-bot mentioned this pull request May 27, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Sep 16, 2021
Open
@awaisab172 awaisab172 mentioned this pull request Jun 21, 2023
Open
@awaisab172 awaisab172 mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gziolo gziolo

Labels
[Feature] Checkout The checkout screen and process for purchases made on WordPress.com. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gziolo @matticbot @scruffian @lancewillett