chore: remove @types/highlight-words-core & @types/gradient-parser
#84333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flootr
added
[Type] Janitorial
dependencies
matticbot
added
the
[Status] Needs Review
1 task
ciampo
reviewed
Nov 20, 2023
There was a problem hiding this comment.
This makes sense to me, although better to have @noahtallen 's approval too (since he's been following this project more closely)
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
noahtallen
approved these changes
Nov 20, 2023
tyxla
force-pushed
the
chore/deps/remove-some-types-packages
branch
from
5c522b9
to
733bd9b
Compare
github-actions
bot
removed
the
[Status] Needs Review
cpapazoglou
pushed a commit
that referenced
this pull request
Dec 11, 2023
#84333) * chore(deps): remove `@types/gradient-parser` * chore(deps): remove `@types/highlight-words-core`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added those packages to compensate
@wordpress/componentsnot shipping with those types. After WordPress/gutenberg#50231 this should be fixed.Proposed Changes
@types/gradient-parser@types/highlight-words-coreTesting Instructions