Translator invitation: add conditional margin to avoid sidebar #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deBhal
added
[Status] Needs Design Review
|
This is already being handled better in #302 |
deBhal
deleted the
fix/469-translator-invitation-styling-with-new-sidebar
branch
lancewillett
removed
the
[Status] Needs Design Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #469
The notifications fixes this problem with a conditional hard-coded margin - https://github.com/Automattic/wp-calypso/blob/fix/469-translator-invitation-styling-with-new-sidebar/client/notices/style.scss#L236
This works, but it seems pretty fragile (not DRY enough) and I'm hoping it's wrong.
You can show the translator invitation by setting
localStorage.calypsoTranslatorInvitationIsPending = trueand then reloading the page anywhere in "My Sites"