-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumping version number and adding latest changes in changelog for privacy-toolset #78912
Bumping version number and adding latest changes in changelog for privacy-toolset #78912
Conversation
…changes relate to the default ticked options when the cookie baner is expanded, leaving advertising un-ticked as default
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have moved to React 18 which is technically a major change. I think this might be a candidate for at least a minor change but I am not sure.
In any case I guess we need to add a line that we migrated react to 18 (PR: #77046)
I will conditionally approve this pending some feedback from others.
8a2800d#diff-9fcbb8bf973925fd282d80241cecafa888d9ea549c830d6a1be64edfcd4ccc6f
@noahtallen @tyxla do you have any thoughts about how to bump versions in relation to the React 18 for automatic packages when being published? I assumed React 18 would be a breaking change but so far it seems like everything has gone pretty smoothly.
Thanks! I've added that to the changelog now. As there are no changes in the code, just a version bump on React, I've kept it at a patch level. Same for the bucket change, as it doesn't add new features, just changing a default value. I can make it a minor version though, if that's the semantic way. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM – but I'll defer to others for deciding on the exact version number.
For most packages, it won't matter since they're used only internally, but for some that are used externally, I'd recommend a major version. React 18 could be a big change for a consumer app and it only makes sense to put the upgrade into a major release. |
Thanks for the context @tyxla ! I made it a major version now. |
Related to #Automattic/martech#1898
Proposed Changes
This bumps the version number to 1.1.1 and adds the latest changes in the changelog file. These changes are related to #78805 where we changed the default ticked buckets when the cookie banner is expanded to leave advertising un-ticked.
Testing Instructions
This does not change any functionality. We just need to merge this before pushing to npmjs, ref: https://github.com/Automattic/wp-calypso/blob/trunk/docs/monorepo.md#publishing
Pre-merge Checklist