Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update e2e test support__popover-invalid #76866

Merged
merged 1 commit into from
May 12, 2023

Conversation

taipeicoder
Copy link
Contributor

@taipeicoder taipeicoder commented May 12, 2023

Proposed Changes

This PR updates tests in support__popover-invalid so that invalid search query terms are expected to return default results instead of empty results. The endpoint payload change is tracked via D110664-code.

Testing Instructions

  • Ensure that the updated tests no longer fail.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@github-actions
Copy link

github-actions bot commented May 12, 2023

@taipeicoder taipeicoder marked this pull request as ready for review May 12, 2023 07:43
@taipeicoder taipeicoder requested review from a team and worldomonation as code owners May 12, 2023 07:43
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 12, 2023
@taipeicoder taipeicoder requested a review from a team May 12, 2023 07:43
@taipeicoder taipeicoder self-assigned this May 12, 2023
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@worldomonation worldomonation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me. Thanks for updating the test step name too!

@taipeicoder taipeicoder merged commit 2cf758c into trunk May 12, 2023
@taipeicoder taipeicoder deleted the fix/specs-support-support-popover-invalid-test branch May 12, 2023 07:57
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 12, 2023
@worldomonation
Copy link
Contributor

It looks like the failure still persists after this change - haven't look into the root cause (whether the expectation is wrong, or the POM needs more work).

Muted the spec for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants