Site Utils: Added canUpdateFiles method to site utils #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enejb
added
Jetpack
[Status] Needs Review
| }, | ||
|
|
||
| canUpdateFiles( site ) { | ||
| if ( site && ! site.hasMinimumJetpackVersion ) { |
There was a problem hiding this comment.
I think we should check for if ( ! site ) at the beginning of the method. So the following ifs doesn't fail if site is undefined.
There was a problem hiding this comment.
I updated the api endpoint so that we don't need this part any more.
enejb
force-pushed
the
fix/improved-file-mod-permissions
branch
from
bed534d to
e27616b
Compare
lezama
added
[Status] Ready to Merge
and removed
[Status] Needs Review
| assert.isFalse( SiteUtils.canUpdateFiles( { hello: 'not important' } ) ); | ||
| } ); | ||
|
|
||
| it( 'canUpdateFiles should return true when passed a site data that will ', function() { |
There was a problem hiding this comment.
"that will..." wait for it 😛
There was a problem hiding this comment.
it's the best way of keeping people interested!
There was a problem hiding this comment.
don't know what you are talking about >> <<
|
Besides @lezama comment, I think this looks pretty good |
… to be more fine grained about what the site objects we allow the to update files
…pdateFiles method
enejb
force-pushed
the
fix/improved-file-mod-permissions
branch
from
6002032 to
922660f
Compare
enejb
added
[Status] Needs Review
lezama
added
[Status] Ready to Merge
and removed
[Status] Needs Review
enejb
added a commit
that referenced
this pull request
Nov 26, 2015
…ions Site Utils: Added canUpdateFiles method to site utils.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds test for
canUpdateFilesmethod on site utils.And removed a deprecated reason for why a site file updates are disabled.
To test
run the tests via make test in the
/client/lib/site/directory viamake testcommand.cc: @johnHackworth, @lezama, @ebinnion