Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup: Minor transitions, contrast, and layout tweaks. #6687

Merged
merged 1 commit into from
Jul 18, 2016

Conversation

shaunandrews
Copy link
Contributor

@shaunandrews shaunandrews commented Jul 11, 2016

This PR aims to bring our contrast rations for text up to WCAG (http://www.w3.org/TR/2008/REC-WCAG20-20081211/#visual-audio-contrast-contrast) AA guidelines. This is a subtle change mostly, but will (hopefully) make all of our copy easier to read.

Here's a GIF showing a before and after example in the first step of signup:

wcag comparison

Watch the step counter and "Family, Home, & Lifestyle" to see the very subtle difference.

This also removes Drake from the domains screen, adjust the colors to be AA compliant, and moving the spacing (padding/margins) to fit in our 8px grid.

Domains Before:
screen shot 2016-07-11 at 3 30 11 pm

Domains After:
screen shot 2016-07-11 at 3 30 07 pm

This also speeds up the transitions between screens, and uses a scale in addition to the existing translate3d.

Test live: https://calypso.live/?branch=update/signup

@shaunandrews shaunandrews added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. NUX [Feature Group] Emails & Domains Features related to email integrations and domain management. labels Jul 11, 2016
@shaunandrews shaunandrews self-assigned this Jul 11, 2016
@shaunandrews shaunandrews changed the title Signup: Minor contrast and layout tweaks. Signup: Minor transitions, contrast, and layout tweaks. Jul 11, 2016
@folletto
Copy link
Contributor

This also removes Drake from the domains screen

Thank you!

Overall, design wise: 👍


Question: can't we just remove... everything below the box? Does this screen really needs the "What are my options?" bit? Isn't automatically clear once one starts typing?

@shaunandrews
Copy link
Contributor Author

Question: can't we just remove... everything below the box? Does this screen really needs the "What are my options?" bit? Isn't automatically clear once one starts typing?

I tend to agree, but didn't want to change things too drastically for fear of affecting conversion. Maybe I already changed it drastically, and should just go all the way. Maybe in a separate PR.

@folletto
Copy link
Contributor

I tend to agree, but didn't want to change things too drastically for fear of affecting conversion. Maybe I already changed it drastically, and should just go all the way. Maybe in a separate PR.

Makes sense. Thanks!

@melchoyce
Copy link
Contributor

Colors look good. 👍

The "options" part of domains feels a little floaty, especially with the super wide domain bar. Need to take a closer look once calypso.live boots up, but I'm thinking:

  • Make the search bar a little more narrow
  • Wrap the "What are my options" header into a headercake
  • Center "Already own..." mapping text
  • Mapping text could also use an icon to help call it out — maybe Globe, Flag, or Location?

@klimeryk
Copy link
Contributor

Stumbled upon this when triaging Domains label - I'd recommend, before doing any drastic changes (not that this PR is proposing such... yet 😉), to:

  • Analyse the history of the component (some changes were probably made based on A/B tests - it'd a shame to throw all that work away).
  • Analyse (if available) relevant analytics. For example, the Map it action triggers events in tracks and GA - maybe we pull some nice info from there like how many users actually click it before search for a domain?

All I'm saying, based on just the discussion in this PR (so a very narrow scope, so sorry if I got the wrong idea), to make best use of previous work and available knowledge 😀

Just my 2 eurocents 😉

@folletto
Copy link
Contributor

FWIW, for reference, this was an alternative original design made by @breezyskies before we went opensource:

dbc85290-578f-11e5-8c05-b83dbde1b4bc

@klimeryk yes, that's the right approach. I mentioned the option to go nuclear there because we discussed in the past to already do that, so I was just re-surfacing it. See also 10097 and 10562 in the repository before open sourcing. I think that test that had the design I reposted above was never completed – I just found a reference it was "stopped", but not the results.

@shaunandrews
Copy link
Contributor Author

screen shot 2016-07-12 at 12 58 24 pm

I updated the domain step based on the feedback above. Hopefully it feels less "floaty" now.

exit.

Adjusting the flow progress indicator’s color to be AA compliant.

Making HeaderCakes’s title AA compliant.

Adjusting step-wrapper buttons to be AA compliant.

Making domain suggestions price AA compliant.

Color and font tweaks to the existing domain suggestions step.
@shaunandrews
Copy link
Contributor Author

shaunandrews commented Jul 18, 2016

Rebased and squashed. In favor of keeping this PR straightforward, I've pulled out the layout changes to the domains step and just focused on color/contrast.

@michaeldcain
Copy link
Member

:shipit:

@michaeldcain michaeldcain added [Status] Ready to Merge and removed [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jul 18, 2016
@shaunandrews shaunandrews merged commit c080cfd into master Jul 18, 2016
@lancewillett lancewillett deleted the update/signup branch September 2, 2016 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management. [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. NUX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants