-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signup: Minor transitions, contrast, and layout tweaks. #6687
Conversation
Thank you! Overall, design wise: 👍 Question: can't we just remove... everything below the box? Does this screen really needs the "What are my options?" bit? Isn't automatically clear once one starts typing? |
I tend to agree, but didn't want to change things too drastically for fear of affecting conversion. Maybe I already changed it drastically, and should just go all the way. Maybe in a separate PR. |
Makes sense. Thanks! |
Colors look good. 👍 The "options" part of domains feels a little floaty, especially with the super wide domain bar. Need to take a closer look once calypso.live boots up, but I'm thinking:
|
Stumbled upon this when triaging
All I'm saying, based on just the discussion in this PR (so a very narrow scope, so sorry if I got the wrong idea), to make best use of previous work and available knowledge 😀 Just my 2 eurocents 😉 |
FWIW, for reference, this was an alternative original design made by @breezyskies before we went opensource: @klimeryk yes, that's the right approach. I mentioned the option to go nuclear there because we discussed in the past to already do that, so I was just re-surfacing it. See also 10097 and 10562 in the repository before open sourcing. I think that test that had the design I reposted above was never completed – I just found a reference it was "stopped", but not the results. |
badf77b
to
bbcb13a
Compare
exit. Adjusting the flow progress indicator’s color to be AA compliant. Making HeaderCakes’s title AA compliant. Adjusting step-wrapper buttons to be AA compliant. Making domain suggestions price AA compliant. Color and font tweaks to the existing domain suggestions step.
bbcb13a
to
ab0d470
Compare
Rebased and squashed. In favor of keeping this PR straightforward, I've pulled out the layout changes to the domains step and just focused on color/contrast. |
|
This PR aims to bring our contrast rations for text up to WCAG (http://www.w3.org/TR/2008/REC-WCAG20-20081211/#visual-audio-contrast-contrast) AA guidelines. This is a subtle change mostly, but will (hopefully) make all of our copy easier to read.
Here's a GIF showing a before and after example in the first step of signup:
Watch the step counter and "Family, Home, & Lifestyle" to see the very subtle difference.
This also removes Drake from the domains screen, adjust the colors to be AA compliant, and moving the spacing (padding/margins) to fit in our 8px grid.
Domains Before:
![screen shot 2016-07-11 at 3 30 11 pm](https://cloud.githubusercontent.com/assets/191598/16743895/7439e412-477c-11e6-9098-53530e105095.png)
Domains After:
![screen shot 2016-07-11 at 3 30 07 pm](https://cloud.githubusercontent.com/assets/191598/16743904/7cda9486-477c-11e6-99f2-1f2cca687044.png)
This also speeds up the transitions between screens, and uses a scale in addition to the existing translate3d.
Test live: https://calypso.live/?branch=update/signup