New Page Layout Picker: refresh page pattern cache when site lang changes #51087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-jackson
added
[Type] Bug
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
roo2
approved these changes
Mar 16, 2021
apps/editing-toolkit/editing-toolkit-plugin/full-site-editing-plugin.php
Show resolved
Hide resolved
|
Works well for me 👍 There are a few e2e test fails which might be related. Are they referring to the former page picker?
|
Yeah I broke tests on |
The `get_verticals_locale()` method in `Starter_Page_Templates` depends on the `get_ios_639_locale()` helper function, so the module with that helper function needs to be executed first before we set up starter page templates.
The page pattern cache was keyed on the account language. However the account language isn't used when making the request to get the page pattern data. Switching to the site's language (i.e. the same locale slug used when fetching pattern data) means the cache will be invalidated correctly.
p-jackson
force-pushed
the
update/refresh-page-pattern-cache-on-site-lang-change
branch
from
9ec100d to
f548912
Compare
|
e2e tests are green 🦖 The php unit tests are failing because of this issue in |
p-jackson
deleted the
update/refresh-page-pattern-cache-on-site-lang-change
branch
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
get_iso_639_locale()function is available when__construct()is calledAfter changing the site language the layout names and categories in the page layout picker still show in the previous language. And when the pattern is inserted it inserts the pervious language. You'd have to wait a day after updating the site language before the picker would fix itself.
The problem is the pattern data is cached using a key that includes the account language, not the site language. This change makes sure the cache key is using the exact same locale slug that's being used in the query to get pattern data.
Testing instructions
install-plugin.sh etk update/refresh-page-pattern-cache-on-site-lang-changeon sandbox