Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoprefixer now recognizes iOS 8 and Safari 8 desktop. #4342

Merged
merged 1 commit into from
Mar 28, 2016

Conversation

DanReyLop
Copy link
Contributor

We claim to support "the latest 2 major versions" of every browser,
but autoprefixer was configured to add vendor prefixes to
"the latest 2 versions". Since it has no concept of "major" or
"minor" versions, as soon as iOS 9.3 was released, only
iOS 9 and iOS 9.3 were supported. Since iOS 8 was the last
supported browser to require -webkit prefix for Flexbox,
it was removed, thus breaking the page layout in those
older Safari browsers.

The solution was to manually add "Safari >= 8" to the list
of browsers for which to generate vendor prefixes.

Autoprefixer was updated to the latest version in the process.

@DanReyLop DanReyLop added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 27, 2016
@DanReyLop DanReyLop self-assigned this Mar 27, 2016
@DanReyLop DanReyLop force-pushed the fix/old-safari-layout branch from 56567be to 1247dfc Compare March 28, 2016 14:51
@rralian
Copy link
Contributor

rralian commented Mar 28, 2016

We need to rebase since we merged #4343. I did run into this issue when testing here.

nodejs error

It's an unrelated issue that has to do with the osx nodejs installer (explained here: nodejs/node#3922). I had to clear out and reinstall npm to make it work. i.e.,

So we may need to let others know about this once we merge this in.

Once I did that this worked fine. I can find no regressions (latest chrome, safari, firefox). Can't test legacy safari at the moment, so I'll let someone else test to make sure that's working. This is a 👍 from me once that is confirmed.

EDIT: Ignore the above... it's bad advice as it introduces a version of npm that we're not yet ready to support. There is a different fix for this in #4359

We claim to support "the latest 2 major versions" of every browser,
but autoprefixer was configured to add vendor prefixes to
"the latest 2 versions". Since it has no concept of "major" or
"minor" versions, as soon as iOS 9.3 was released, only
iOS 9 and iOS 9.3 were supported. Since iOS 8 was the last
supported browser to require -webkit prefix for Flexbox,
it was removed, thus breaking the page layout in those
older Safari browsers.

The solution was to manually add "Safari >= 8" to the list
of browsers for which to generate vendor prefixes.

Autoprefixer was updated to the latest version in the process.
@DanReyLop DanReyLop force-pushed the fix/old-safari-layout branch from 1247dfc to 6a9a60f Compare March 28, 2016 15:50
@DanReyLop
Copy link
Contributor Author

Ok, I've just rebased it.

@rralian
Copy link
Contributor

rralian commented Mar 28, 2016

Just tested on legacy safari via browserstack and I see the -webkit prefixes getting generated for flex now and the masterbar is lining up and working. This looks 🚢-ready to me.

legacy safari working correctly

@rralian rralian added Framework [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 28, 2016
@rralian rralian merged commit cb6b4fc into master Mar 28, 2016
@rralian rralian deleted the fix/old-safari-layout branch March 28, 2016 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants