-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/npm to yarn main #41140
Update/npm to yarn main #41140
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~21 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~7992 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~83519 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
17eea42
to
86fc8f1
Compare
Caution: This PR affects files in the FSE Plugin on WordPress.com D41901-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing in the FSE Plugin for more info: PCYsg-ly5-p2 |
a580a28
to
2589319
Compare
* Update docs to use yarn in examples * Undo accidental change in CREDITS
* Fixes yarn version to 1.22.4 using yarn version policies * Do not lint .yarn
* Replace `npm` commands with `yarn` equivalents * Update CircleCI config * Remove yarn.lock file, doesn't belong to this PR * Fix typo in build-css script * Add yarn.lock to pass CI * Update yarn.lock without workspaces to make CI happy * Add missing vfile-message to force hoisting * Link packages using yarn workspaces * Update yarn.lock
* Replace `npm` commands with `yarn` equivalents * Update yarn.lock without workspaces to make CI happy * Update yarn.lock * Link packages using yarn workspaces * Replace `npm` commands with `yarn` equivalents * Update yarn.lock * Update yarn.lock * Tweak domutils and p-limit to match npm tree * Update yarn.lock
c36f468
to
7d3fe38
Compare
This branch will introduce the following changes in the dependency tree (compared with master in 1d03056):
How to read the tableThe first column shows the package, and the second column shows a dependency range of that package. The third column is how NPM resolved that range in our current tree, the fourth column is how YARN will resolve it in this PR. Example:
Why this happensThe easiest way to understand this is that once yarn sees a dependency range in the tree (eg: This was not true in NPM, where the same dependency can be resolved by different versions in different parts of the tree. Resolution strategyWhen possible, I've changed the dependency tree to bump a version instead of downgrading an existing one. For example, before However, this was not always possible. For example, ValidationHere is how you can generate the data yourself and check it is correct:
|
Note about failing Unfortunately, So The plan is to have a PR in /cc @nsakaimbo |
Changes proposed in this Pull Request
Testing instructions
Nothing really to review/test, the content of this PR has been already tested/reviewed following the plan in #40882
I'll add extra notes if something pops up.