Revert "fix(deps): update dependency terser-webpack-plugin to v2.3.4" #39400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwwar
approved these changes
Feb 12, 2020
|
A bunch of babel updates, which appeared to be harmless movement inside node_modules, slipped in with this update because the original lockfile generated by npm was broken. This update didn't actually update terser, just the webpack plugin for it. We're not entirely sure why this broke Edge 18 just yet. |
|
cc @sgomes We missed this in part because there are no automated tests that target Edge. We've been relying on Chrome to cover it, especially now that Edge is moving to Chromium. We may want to spin up a Sauce Edge instance for a canary while it's still supported. |
|
+1 on having a canary for every platform we support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #39309
Throwing errors in Edge 18