Woo: Shipping Labels: Use Stripe Elements for Add Credit Card Dialog #35390

sirbrillig · 2019-08-14T20:34:06Z

Changes proposed in this Pull Request

This updates the AddCardDialog Woo component to use Stripe Elements and Payment Intents (see previous work in #34848, #35262, and #35351).

Depends on Woo: AddCardDialog: Refactor as functional component #35414

Testing instructions

Sandbox the store.
Purchase a Business plan.
Create a Store (further instructions are needed here).
Visit http://calypso.localhost:3000/store/settings/shipping/ and choose the site with the Store.
Click "Settings" in the sidebar.
Click the "Shipping" tab.
In the "Shipping Labels" section, click "Add credit card" or "Add another credit card".
Verify that the resulting form's credit card field has numbers as placeholders rather than dots. This proves that you are seeing the Stripe fields.
Fill out the form with a Stripe test card (see https://stripe.com/docs/testing#cards) and press "Save Card".
Verify that the card was successfully added and appears in the list (it will have no expiry date until the page is reloaded; this is expected behavior).
Repeat the above steps with a new card that requires 3DS.

matticbot · 2019-08-14T20:34:08Z

Test live: https://calypso.live/?branch=update/woo-add-card-modal-stripe-elements

a8ci18n · 2019-08-14T20:38:20Z

...nt/extensions/woocommerce/woocommerce-services/views/label-settings/add-credit-card-modal.js

+				saveStoredCard={ saveStoredCard }
+				successCallback={ onClose }
+				showUsedForExistingPurchasesInfo={ true }
+				heading={ translate( 'Add credit card' ) }


Hi! I've found a possible matching string that has already been translated 43 times:
translate( 'Add Credit Card' ) ES Score: 10
See 2 additional suggestions in the PR translation status page

Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).

I think we got this message because we intentionally don't translate this section (shipping labels are only available in the US/Canada IIRC)

matticbot · 2019-08-14T20:43:10Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Webpack Runtime (~30062 bytes added 📈 [gzipped])

name      parsed_size         gzip_size
manifest    +166718 B  (new)   +30062 B  (new)

Webpack runtime for loading modules. It is included in the HTML page as an inline script. Is downloaded and parsed every time the app is loaded.

App Entrypoints (~553278 bytes added 📈 [gzipped])

name                   parsed_size         gzip_size
entry-main              +1664712 B  (new)  +399167 B  (new)
entry-domains-landing    +575596 B  (new)  +154111 B  (new)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legacy SCSS Stylesheet (~22810 bytes added 📈 [gzipped])

name       parsed_size         gzip_size
style.css    +139292 B  (new)   +22810 B  (new)

The monolithic CSS stylesheet that is downloaded on every app load.
👎 This PR increases the size of the stylesheet, which is a bad news. Please consider migrating the CSS styles you modified to webpack imports.

Sections (~5907469 bytes added 📈 [gzipped])

name                      parsed_size         gzip_size
woocommerce                +2253276 B  (new)  +571888 B  (new)
post-editor                +1887574 B  (new)  +507426 B  (new)
domains                     +943024 B  (new)  +214345 B  (new)
purchases                   +926461 B  (new)  +220549 B  (new)
checkout                    +919828 B  (new)  +218102 B  (new)
marketing                   +781406 B  (new)  +193994 B  (new)
stats                       +778249 B  (new)  +191443 B  (new)
gutenberg-editor            +687618 B  (new)  +188941 B  (new)
jetpack-connect             +614558 B  (new)  +157747 B  (new)
settings                    +598882 B  (new)  +148830 B  (new)
help                        +589875 B  (new)  +144903 B  (new)
plans                       +560624 B  (new)  +142381 B  (new)
plugins                     +559701 B  (new)  +139558 B  (new)
comments                    +540605 B  (new)  +124363 B  (new)
settings-writing            +483893 B  (new)  +117801 B  (new)
activity                    +441947 B  (new)  +109040 B  (new)
security                    +418150 B  (new)  +107254 B  (new)
themes                      +412779 B  (new)  +105998 B  (new)
reader                      +394824 B  (new)   +99710 B  (new)
account-close               +385048 B  (new)   +99184 B  (new)
media                       +384944 B  (new)   +99350 B  (new)
people                      +378079 B  (new)   +94381 B  (new)
email                       +377456 B  (new)   +95259 B  (new)
account                     +336661 B  (new)   +88722 B  (new)
theme                       +334862 B  (new)   +85650 B  (new)
notification-settings       +331215 B  (new)   +82536 B  (new)
posts-pages                 +326663 B  (new)   +82333 B  (new)
concierge                   +314443 B  (new)   +74484 B  (new)
google-my-business          +289848 B  (new)   +77979 B  (new)
posts-custom                +287825 B  (new)   +72506 B  (new)
export                      +281492 B  (new)   +71526 B  (new)
signup                      +261641 B  (new)   +65641 B  (new)
happychat                   +260122 B  (new)   +69961 B  (new)
earn                        +258798 B  (new)   +63634 B  (new)
site-blocks                 +257321 B  (new)   +67729 B  (new)
customize                   +256874 B  (new)   +66852 B  (new)
privacy                     +238474 B  (new)   +63000 B  (new)
home                        +237165 B  (new)   +61551 B  (new)
wp-super-cache              +236038 B  (new)   +58177 B  (new)
me                          +233090 B  (new)   +61520 B  (new)
settings-security           +225816 B  (new)   +56416 B  (new)
checklist                   +225436 B  (new)   +58462 B  (new)
zoninator                   +217895 B  (new)   +55496 B  (new)
import                      +214988 B  (new)   +55120 B  (new)
settings-performance        +209399 B  (new)   +54482 B  (new)
settings-discussion         +179737 B  (new)   +44761 B  (new)
accept-invite               +166485 B  (new)   +43336 B  (new)
feature-upsell              +147654 B  (new)   +34683 B  (new)
login                       +144106 B  (new)   +38117 B  (new)
devdocs                     +129946 B  (new)   +36102 B  (new)
hello-dolly                  +94625 B  (new)   +25917 B  (new)
preview                      +93853 B  (new)   +25612 B  (new)
sensei                       +89854 B  (new)   +24230 B  (new)
sites                        +87752 B  (new)   +23666 B  (new)
jetpack-onboarding           +56184 B  (new)   +13541 B  (new)
auth                         +19215 B  (new)    +5506 B  (new)
domain-connect-authorize     +13397 B  (new)    +3808 B  (new)
mailing-lists                 +6764 B  (new)    +1966 B  (new)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~2637207 bytes added 📈 [gzipped])

name                                                         parsed_size         gzip_size
async-load-design-blocks                                      +2699597 B  (new)  +621792 B  (new)
async-load-design                                             +1875506 B  (new)  +431325 B  (new)
async-load-design-playground                                  +1717182 B  (new)  +393766 B  (new)
async-load-components-web-preview-component                    +351457 B  (new)   +87613 B  (new)
async-load-blocks-inline-help-popover                          +342365 B  (new)   +82168 B  (new)
async-load-post-editor-media-modal                             +293631 B  (new)   +76679 B  (new)
async-load-blocks-calendar-popover                             +243545 B  (new)   +47611 B  (new)
async-load-signup-steps-domains                                +215932 B  (new)   +51909 B  (new)
async-load-signup-steps-clone-point                            +171847 B  (new)   +40087 B  (new)
async-load-my-sites-current-site-notice                        +148153 B  (new)   +36749 B  (new)
async-load-signup-steps-plans                                  +143924 B  (new)   +38497 B  (new)
async-load-my-sites-checklist-wpcom-checklist-component-jsx    +141821 B  (new)   +34129 B  (new)
async-load-reader-following-manage                             +140595 B  (new)   +36212 B  (new)
async-load-my-sites-current-site-stale-cart-items-notice       +127472 B  (new)   +31587 B  (new)
async-load-apps-notifications-index-jsx                        +123972 B  (new)   +35330 B  (new)
async-load-emoji-text                                          +118129 B  (new)   +22332 B  (new)
async-load-reader-search-stream                                +113969 B  (new)   +29353 B  (new)
async-load-signup-steps-plans-atomic-store                     +111671 B  (new)   +29490 B  (new)
async-load-layout-guided-tours-component                        +97347 B  (new)   +20650 B  (new)
async-load-jquery                                               +97345 B  (new)   +33801 B  (new)
async-load-signup-steps-user                                    +92638 B  (new)   +23925 B  (new)
async-load-blocks-inline-help                                   +73460 B  (new)   +17016 B  (new)
async-load-lib-happychat-connection                             +63635 B  (new)   +17468 B  (new)
async-load-my-sites-current-site-domain-warnings                +56556 B  (new)   +14378 B  (new)
async-load-signup-steps-about                                   +52281 B  (new)   +13638 B  (new)
async-load-blocks-support-article-dialog-dialog                 +50389 B  (new)   +15384 B  (new)
async-load-extensions-woocommerce-app-store-stats               +47985 B  (new)   +13037 B  (new)
async-load-extensions-woocommerce-app-store-stats-referrers     +47686 B  (new)   +12929 B  (new)
async-load-signup-steps-clone-credentials                       +44372 B  (new)   +11147 B  (new)
async-load-blocks-reader-full-post                              +43971 B  (new)   +11620 B  (new)
async-load-signup-steps-rewind-form-creds                       +42218 B  (new)   +10714 B  (new)
async-load-reader-sidebar                                       +41849 B  (new)   +10287 B  (new)
async-load-signup-steps-import-url-onboarding                   +38831 B  (new)   +11563 B  (new)
async-load-layout-guided-tours                                  +37944 B  (new)   +10543 B  (new)
async-load-signup-steps-theme-selection                         +37897 B  (new)    +9892 B  (new)
async-load-components-happychat                                 +34104 B  (new)   +11027 B  (new)
async-load-quick-language-switcher                              +30282 B  (new)    +8387 B  (new)
async-load-reader-site-stream                                   +28856 B  (new)    +7684 B  (new)
async-load-signup-steps-clone-ready                             +28788 B  (new)    +7942 B  (new)
async-load-reader-feed-stream                                   +28727 B  (new)    +7610 B  (new)
async-load-signup-steps-site-topic                              +28138 B  (new)    +7586 B  (new)
async-load-layout-nps-survey-notice                             +26616 B  (new)    +6833 B  (new)
async-load-signup-steps-passwordless                            +26142 B  (new)    +6396 B  (new)
async-load-signup-steps-site                                    +26082 B  (new)    +6559 B  (new)
async-load-signup-steps-import-url                              +26066 B  (new)    +7014 B  (new)
async-load-signup-steps-rewind-migrate                          +25763 B  (new)    +7094 B  (new)
async-load-my-sites-guided-transfer                             +24550 B  (new)    +5821 B  (new)
async-load-signup-steps-creds-confirm                           +24418 B  (new)    +6547 B  (new)
async-load-post-editor-editor-sharing-accordion                 +24312 B  (new)    +6037 B  (new)
async-load-components-jetpack-header-inmotion                   +24228 B  (new)    +7238 B  (new)
async-load-signup-steps-creds-permission                        +24211 B  (new)    +6508 B  (new)
async-load-signup-steps-clone-destination                       +19736 B  (new)    +5291 B  (new)
async-load-signup-steps-site-or-domain                          +19066 B  (new)    +5384 B  (new)
async-load-post-editor-editor-author                            +19058 B  (new)    +5404 B  (new)
async-load-components-jetpack-header-dreamhost                  +18513 B  (new)    +5595 B  (new)
async-load-reader-tag-stream-main                               +18025 B  (new)    +5211 B  (new)
async-load-signup-steps-survey                                  +17931 B  (new)    +4520 B  (new)
async-load-components-jetpack-header-pressable                  +17386 B  (new)    +5324 B  (new)
async-load-extensions-woocommerce-app-store-stats-listview      +17251 B  (new)    +4852 B  (new)
async-load-components-jetpack-header-liquidweb                  +16491 B  (new)    +5797 B  (new)
async-load-signup-steps-rebrand-cities-welcome                  +14101 B  (new)    +3678 B  (new)
async-load-signup-steps-clone-start                             +14002 B  (new)    +4054 B  (new)
async-load-signup-steps-clone-cloning                           +13508 B  (new)    +3925 B  (new)
async-load-layout-community-translator-launcher                 +13171 B  (new)    +4688 B  (new)
async-load-signup-steps-site-style                              +13083 B  (new)    +3493 B  (new)
async-load-components-jetpack-header-bluehost                   +11601 B  (new)    +3370 B  (new)
async-load-signup-steps-site-title                              +11501 B  (new)    +3092 B  (new)
async-load-signup-steps-reader-landing                          +11057 B  (new)    +2911 B  (new)
async-load-signup-steps-site-type                               +11054 B  (new)    +3059 B  (new)
async-load-signup-steps-clone-jetpack                           +10801 B  (new)    +2831 B  (new)
async-load-post-editor-editor-location                          +10494 B  (new)    +3181 B  (new)
async-load-reader-list-stream                                   +10373 B  (new)    +2912 B  (new)
async-load-components-jetpack-header-eurodns                     +9905 B  (new)    +2486 B  (new)
async-load-components-community-translator                       +8906 B  (new)    +2808 B  (new)
async-load-signup-steps-rewind-add-creds                         +8737 B  (new)    +2505 B  (new)
async-load-signup-steps-rewind-were-backing                      +8624 B  (new)    +2528 B  (new)
async-load-signup-steps-site-picker                              +8555 B  (new)    +2495 B  (new)
async-load-signup-steps-creds-complete                           +8544 B  (new)    +2533 B  (new)
async-load-layout-masterbar-drafts-popover                       +8145 B  (new)    +2644 B  (new)
async-load-signup-steps-test-step                                +7692 B  (new)    +2239 B  (new)
async-load-components-jetpack-header                             +6969 B  (new)    +2198 B  (new)
async-load-components-signup-site-preview-component              +6651 B  (new)    +1988 B  (new)
async-load-post-editor-editor-seo-accordion                      +6028 B  (new)    +1975 B  (new)
async-load-docs-selectors                                        +6007 B  (new)    +1874 B  (new)
async-load-post-editor-editor-post-formats-accordion             +5747 B  (new)    +1856 B  (new)
async-load-components-jetpack-header-woocommerce                 +5622 B  (new)    +1453 B  (new)
async-load-design-typography                                     +5516 B  (new)    +1678 B  (new)
async-load-post-editor-editor-discussion                         +5332 B  (new)    +1701 B  (new)
async-load-blocks-inline-help-dialog                             +5154 B  (new)    +2017 B  (new)
async-load-blocks-login-social-connect-prompt                    +4836 B  (new)    +1774 B  (new)
async-load-reader-conversations-stream                           +4637 B  (new)    +1659 B  (new)
async-load-lib-network-connection                                +4314 B  (new)    +1586 B  (new)
async-load-lib-preferences-helper                                +4140 B  (new)    +1120 B  (new)
async-load-featured-image                                        +3229 B  (new)    +1110 B  (new)
async-load-components-webpack-build-monitor                      +2901 B  (new)    +1280 B  (new)
async-load-lib-abtest-test-helper                                +2076 B  (new)     +893 B  (new)
async-load-components-jetpack-header-milesweb                     +645 B  (new)     +418 B  (new)
async-load-signup-steps-launch-site                               +545 B  (new)     +337 B  (new)
async-load-lib-rubberband-scroll-disable                          +491 B  (new)     +305 B  (new)
async-load-reader-team-main                                       +384 B  (new)     +271 B  (new)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Moment.js Locales (~108637 bytes added 📈 [gzipped])

name                    parsed_size         gzip_size
moment-locale-ru            +4549 B  (new)    +1608 B  (new)
moment-locale-mr            +3431 B  (new)    +1273 B  (new)
moment-locale-uk            +3274 B  (new)    +1448 B  (new)
moment-locale-bo            +3244 B  (new)    +1072 B  (new)
moment-locale-ta            +3020 B  (new)    +1162 B  (new)
moment-locale-be            +2951 B  (new)    +1294 B  (new)
moment-locale-cs            +2880 B  (new)    +1169 B  (new)
moment-locale-ka            +2754 B  (new)     +994 B  (new)
moment-locale-kn            +2749 B  (new)    +1148 B  (new)
moment-locale-ar            +2657 B  (new)    +1184 B  (new)
moment-locale-ne            +2571 B  (new)    +1106 B  (new)
moment-locale-sr-cyrl       +2516 B  (new)    +1090 B  (new)
moment-locale-ar-ly         +2502 B  (new)    +1109 B  (new)
moment-locale-gu            +2499 B  (new)    +1086 B  (new)
moment-locale-el            +2482 B  (new)    +1219 B  (new)
moment-locale-bn            +2467 B  (new)    +1049 B  (new)
moment-locale-sl            +2460 B  (new)     +992 B  (new)
moment-locale-pa-in         +2455 B  (new)    +1020 B  (new)
moment-locale-ml            +2403 B  (new)     +954 B  (new)
moment-locale-hi            +2365 B  (new)    +1073 B  (new)
moment-locale-ug-cn         +2364 B  (new)    +1019 B  (new)
moment-locale-lt            +2318 B  (new)    +1101 B  (new)
moment-locale-km            +2316 B  (new)    +1007 B  (new)
moment-locale-te            +2285 B  (new)     +959 B  (new)
moment-locale-es-us         +2207 B  (new)     +944 B  (new)
moment-locale-es-do         +2207 B  (new)     +945 B  (new)
moment-locale-es            +2190 B  (new)     +940 B  (new)
moment-locale-mn            +2183 B  (new)     +969 B  (new)
moment-locale-sk            +2148 B  (new)     +932 B  (new)
moment-locale-tlh           +2141 B  (new)     +890 B  (new)
moment-locale-hy-am         +2135 B  (new)     +965 B  (new)
moment-locale-my            +2134 B  (new)     +935 B  (new)
moment-locale-hr            +2123 B  (new)     +939 B  (new)
moment-locale-th            +2105 B  (new)     +859 B  (new)
moment-locale-ku            +2085 B  (new)     +973 B  (new)
moment-locale-pl            +2065 B  (new)     +995 B  (new)
moment-locale-tg            +2063 B  (new)     +990 B  (new)
moment-locale-si            +2058 B  (new)     +863 B  (new)
moment-locale-me            +2043 B  (new)     +956 B  (new)
moment-locale-lo            +2042 B  (new)     +811 B  (new)
moment-locale-fa            +2032 B  (new)     +937 B  (new)
moment-locale-sr            +2025 B  (new)     +952 B  (new)
moment-locale-hu            +2016 B  (new)     +931 B  (new)
moment-locale-nl-be         +2000 B  (new)     +939 B  (new)
moment-locale-nl            +1991 B  (new)     +936 B  (new)
moment-locale-fi            +1980 B  (new)     +894 B  (new)
moment-locale-bs            +1973 B  (new)     +877 B  (new)
moment-locale-gom-latn      +1965 B  (new)     +961 B  (new)
moment-locale-he            +1938 B  (new)     +878 B  (new)
moment-locale-ar-sa         +1926 B  (new)     +919 B  (new)
moment-locale-is            +1923 B  (new)     +896 B  (new)
moment-locale-lv            +1893 B  (new)     +848 B  (new)
moment-locale-ca            +1821 B  (new)     +856 B  (new)
moment-locale-tzm           +1819 B  (new)     +653 B  (new)
moment-locale-lb            +1814 B  (new)     +944 B  (new)
moment-locale-ky            +1783 B  (new)     +907 B  (new)
moment-locale-kk            +1772 B  (new)     +886 B  (new)
moment-locale-az            +1764 B  (new)     +918 B  (new)
moment-locale-zh-cn         +1757 B  (new)     +921 B  (new)
moment-locale-zh-tw         +1755 B  (new)     +906 B  (new)
moment-locale-zh-hk         +1750 B  (new)     +907 B  (new)
moment-locale-mk            +1748 B  (new)     +910 B  (new)
moment-locale-bg            +1728 B  (new)     +915 B  (new)
moment-locale-cv            +1697 B  (new)     +817 B  (new)
moment-locale-tzl           +1633 B  (new)     +867 B  (new)
moment-locale-dv            +1572 B  (new)     +818 B  (new)
moment-locale-br            +1552 B  (new)     +838 B  (new)
moment-locale-x-pseudo      +1533 B  (new)     +853 B  (new)
moment-locale-ja            +1531 B  (new)     +770 B  (new)
moment-locale-vi            +1530 B  (new)     +770 B  (new)
moment-locale-ss            +1517 B  (new)     +804 B  (new)
moment-locale-gl            +1517 B  (new)     +737 B  (new)
moment-locale-et            +1496 B  (new)     +767 B  (new)
moment-locale-tr            +1493 B  (new)     +804 B  (new)
moment-locale-ko            +1481 B  (new)     +733 B  (new)
moment-locale-mi            +1476 B  (new)     +748 B  (new)
moment-locale-de-at         +1469 B  (new)     +759 B  (new)
moment-locale-de-ch         +1460 B  (new)     +743 B  (new)
moment-locale-de            +1458 B  (new)     +752 B  (new)
moment-locale-ar-dz         +1449 B  (new)     +685 B  (new)
moment-locale-ar-tn         +1433 B  (new)     +679 B  (new)
moment-locale-ar-ma         +1430 B  (new)     +682 B  (new)
moment-locale-ar-kw         +1430 B  (new)     +680 B  (new)
moment-locale-uz            +1429 B  (new)     +709 B  (new)
moment-locale-cy            +1421 B  (new)     +762 B  (new)
moment-locale-jv            +1413 B  (new)     +737 B  (new)
moment-locale-fy            +1409 B  (new)     +769 B  (new)
moment-locale-yo            +1400 B  (new)     +704 B  (new)
moment-locale-fr            +1386 B  (new)     +726 B  (new)
moment-locale-gd            +1381 B  (new)     +759 B  (new)
moment-locale-eu            +1375 B  (new)     +691 B  (new)
moment-locale-fr-ch         +1371 B  (new)     +724 B  (new)
moment-locale-ms-my         +1370 B  (new)     +721 B  (new)
moment-locale-ms            +1361 B  (new)     +719 B  (new)
moment-locale-ur            +1355 B  (new)     +730 B  (new)
moment-locale-sd            +1354 B  (new)     +754 B  (new)
moment-locale-ga            +1352 B  (new)     +738 B  (new)
moment-locale-fr-ca         +1352 B  (new)     +712 B  (new)
moment-locale-id            +1348 B  (new)     +717 B  (new)
moment-locale-eo            +1337 B  (new)     +734 B  (new)
moment-locale-af            +1330 B  (new)     +727 B  (new)
moment-locale-se            +1325 B  (new)     +707 B  (new)
moment-locale-pt-br         +1314 B  (new)     +701 B  (new)
moment-locale-it-ch         +1310 B  (new)     +720 B  (new)
moment-locale-pt            +1305 B  (new)     +702 B  (new)
moment-locale-it            +1301 B  (new)     +717 B  (new)
moment-locale-sq            +1290 B  (new)     +701 B  (new)
moment-locale-sv            +1282 B  (new)     +699 B  (new)
moment-locale-tet           +1263 B  (new)     +689 B  (new)
moment-locale-en-nz         +1256 B  (new)     +687 B  (new)
moment-locale-en-au         +1256 B  (new)     +686 B  (new)
moment-locale-en-SG         +1252 B  (new)     +687 B  (new)
moment-locale-en-gb         +1252 B  (new)     +687 B  (new)
moment-locale-en-ie         +1251 B  (new)     +686 B  (new)
moment-locale-bm            +1244 B  (new)     +634 B  (new)
moment-locale-en-ca         +1240 B  (new)     +676 B  (new)
moment-locale-ro            +1223 B  (new)     +712 B  (new)
moment-locale-nb            +1223 B  (new)     +644 B  (new)
moment-locale-en-il         +1217 B  (new)     +668 B  (new)
moment-locale-tl-ph         +1216 B  (new)     +657 B  (new)
moment-locale-fo            +1203 B  (new)     +659 B  (new)
moment-locale-tzm-latn      +1187 B  (new)     +565 B  (new)
moment-locale-nn            +1184 B  (new)     +641 B  (new)
moment-locale-mt            +1173 B  (new)     +678 B  (new)
moment-locale-da            +1163 B  (new)     +632 B  (new)
moment-locale-sw            +1159 B  (new)     +632 B  (new)
moment-locale-uz-latn       +1155 B  (new)     +598 B  (new)

Locale data for moment.js. Unless you are upgrading the moment.js library, changes in these chunks are suspicious.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

The `PaymentMethod` component has an optional `expiry` prop, but if the prop is empty, then the component displays the word "Expires" without a date. This makes sure nothing is rendered if there is no expiry available.

yoavf

LGTM, and works as it should. I don't know if the e2e tests failures are related though.

yoavf · 2019-08-16T11:59:16Z

The failing test seems unrelated - p1565940337031800-e2e-testing-discuss

a8ci18n reviewed Aug 14, 2019

View reviewed changes

sirbrillig mentioned this pull request Aug 15, 2019

Woo: AddCardDialog: Refactor as functional component #35414

Merged

sirbrillig marked this pull request as ready for review August 15, 2019 17:12

sirbrillig requested a review from dechov August 15, 2019 17:13

sirbrillig added 2 commits August 15, 2019 18:23

AddCardDialog: Switch to using Stripe Elements

184af6a

Woo PaymentMethod Label: Hide expiry text when not available

700b763

The `PaymentMethod` component has an optional `expiry` prop, but if the prop is empty, then the component displays the word "Expires" without a date. This makes sure nothing is rendered if there is no expiry available.

sirbrillig force-pushed the update/woo-add-card-modal-stripe-elements branch from 3479a38 to 700b763 Compare August 15, 2019 22:23

yoavf approved these changes Aug 16, 2019

View reviewed changes

sirbrillig merged commit a7ec2af into master Aug 16, 2019

sirbrillig deleted the update/woo-add-card-modal-stripe-elements branch August 16, 2019 14:25

sirbrillig mentioned this pull request Sep 30, 2019

Checkout: Use Context for Stripe data #36059

Merged

6 tasks

sirbrillig mentioned this pull request Oct 30, 2020

Payments: Move lib/stripe to calypso-stripe package #46973

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Woo: Shipping Labels: Use Stripe Elements for Add Credit Card Dialog #35390

Woo: Shipping Labels: Use Stripe Elements for Add Credit Card Dialog #35390

sirbrillig commented Aug 14, 2019 •

edited

Loading

matticbot commented Aug 14, 2019

a8ci18n Aug 14, 2019

yoavf Aug 15, 2019

matticbot commented Aug 14, 2019 •

edited

Loading

yoavf left a comment

yoavf commented Aug 16, 2019

Woo: Shipping Labels: Use Stripe Elements for Add Credit Card Dialog #35390

Woo: Shipping Labels: Use Stripe Elements for Add Credit Card Dialog #35390

Conversation

sirbrillig commented Aug 14, 2019 • edited Loading

Changes proposed in this Pull Request

Testing instructions

matticbot commented Aug 14, 2019

a8ci18n Aug 14, 2019

Choose a reason for hiding this comment

yoavf Aug 15, 2019

Choose a reason for hiding this comment

matticbot commented Aug 14, 2019 • edited Loading

yoavf left a comment

Choose a reason for hiding this comment

yoavf commented Aug 16, 2019

sirbrillig commented Aug 14, 2019 •

edited

Loading

matticbot commented Aug 14, 2019 •

edited

Loading