Reader: Add a back button to site and feed streams #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blowery
added
[Status] Needs Review
blowery
changed the title
blowery
added
the
[Status] Needs Design Review
| @@ -140,6 +151,7 @@ var FeedStream = React.createClass( { | |||
|
|
|||
| return ( | |||
| <FollowingStream { ...this.props } listName={ this.state.title } emptyContent={ emptyContent } > | |||
| { this.props.showBack ? <HeaderCake isCompact={ false } onClick={ this.goBack } /> : null } | |||
There was a problem hiding this comment.
What about writing { this.props.showBack && <HeaderCake /> } with the null being implicit?
There was a problem hiding this comment.
Makes me slightly nervous because when showBack is falsey, it'll render whatever is in showBack, which may not be null.
There was a problem hiding this comment.
It works as-expected with false, so maybe just enforce the boolean proptype?
There was a problem hiding this comment.
+1 for using a ternary. Saw another PR earlier today that had its check value being rendered to the page.
|
👍 tested in Chrome, FF, IE11, Edge. |
gwwar
added
[Status] Ready to Merge
and removed
[Status] Needs Review
blowery
added a commit
that referenced
this pull request
Dec 8, 2015
…r-streams Reader: Add a back button to site and feed streams
blowery
removed
the
[Status] Needs Design Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the ability to override it.