Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg: suppress strict mode console warnings #28225

Merged
merged 1 commit into from
Nov 2, 2018
Merged

Gutenberg: suppress strict mode console warnings #28225

merged 1 commit into from
Nov 2, 2018

Conversation

vindl
Copy link
Member

@vindl vindl commented Nov 1, 2018

Changes proposed in this Pull Request

There are still a few console warnings that haven't been yet fixed in core. This is removing the strict mode to aid our developer experience and to make the job of scanning the console for legitimate
new errors easier. These warnings are strictly core-related and are not helping our Calypso work in any way.

Testing instructions

  1. Navigate to http://calypso.localhost:3000/gutenberg/post
  2. Observe to console and notice that there are no more console warnings present (like the ones from Gutenberg: fix console errors and warnings #26643).

Fixes #26643

@vindl
Gutenberg: suppress strict mode console warnings
f2efcdb 
There are still a few console warnings that haven't been yet fixed
in core. This is removing the strict mode to aid our developer
experience and to make the job of scanning the console for legitimate
new errors easier.
@vindl vindl added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Goal] Gutenberg Working towards full integration with Gutenberg labels Nov 1, 2018
@vindl vindl self-assigned this Nov 1, 2018
@vindl vindl requested a review from a team November 1, 2018 20:33
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=fix/gutenberg-console-warnings

mmtr
mmtr reviewed Nov 2, 2018
View reviewed changes
Copy link
Member

@mmtr mmtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anymore the console warnings described in #26643.

However, I still see some other error messages.
screen shot 2018-11-02 at 10 54 01

I guess they're not related to this and they are caused by a different issue, but just wanted to confirm.

@vindl
Copy link
Member Author

vindl commented Nov 2, 2018 •
edited
Loading

@mmtr these are all known separate issues and "expected". This PR only deals with console warnings, not console errors.

mmtr
mmtr approved these changes Nov 2, 2018
View reviewed changes
Copy link
Member

@mmtr mmtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@vindl vindl merged commit e1e78f0 into master Nov 2, 2018
@vindl vindl deleted the fix/gutenberg-console-warnings branch November 2, 2018 10:36
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 2, 2018
@gwwar
Copy link
Contributor

gwwar commented Nov 2, 2018

Re the jetpack console error, those are outstanding i18n issues from the SDK that remain unsolved. pa9srA-W-p2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmtr mmtr mmtr approved these changes

Assignees

@vindl vindl

Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gutenberg: fix console errors and warnings
4 participants
@vindl @matticbot @gwwar @mmtr