SDK: Try wp.data with calypso state tree "rewrite" #26930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Status] Needs Review
coderkevin
reviewed
Aug 29, 2018
| errorLogger.saveDiagnosticReducer( () => ( { tests: getSavedVariations() } ) ); | ||
| analytics.on( 'record-event', ( eventName, eventProperties ) => | ||
| errorLogger.saveExtraData( { lastTracksEvent: eventProperties } ) | ||
| if ( config.isEnabled( 'catch-js-errors' ) && ! document.getElementById( 'primary' ) ) { |
There was a problem hiding this comment.
This code seems extraneous to this PR's purpose. If it's a separate improvement, would it make sense to put it in a standalone PR?
There was a problem hiding this comment.
It's in #26944 for separate review, but I'm leaving it included on this branch since it wouldn't work otherwise. (tl;dr this extraneous -- and obsolete -- empty Layout would leave wpRegistry undefined upon first render of RegistryProvider, and that breaks things quite badly).
There was a problem hiding this comment.
I see. If you want them reviewed separately, you may want to switch the base of this PR to that branch then.
|
I suppose this can be closed? |
|
I'll close this, feel free to reopen if you'd like. |
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Alternative to #26838.
Includes #26944, so review & merge that PR before rebasing this one.
withSelect/withDispatch@wordpress/data'sRegistryProviderstate.subtree.somethingtostate.something)connecttowithSelectTo Test:
http://calypso.localhost:3000/me/accountand change the "Admin Color Scheme"withSelectnow.