Framework: upgrade enzyme #19448
Merged
Framework: upgrade enzyme #19448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
samouri
added
Framework
[Status] In Progress
[Status] Needs Review
ockham
force-pushed
the
upgrade/jest-enzyme
branch
from
679601e to
6c99356
Compare
|
Rebased, reshrunk. |
gziolo
approved these changes
Nov 3, 2017
matticbot
removed
the
[Status] Needs Review
rclations
pushed a commit
to rclations/wp-calypso
that referenced
this pull request
Nov 15, 2017
* add enzyme adapter * Upgrade Enzyme * update snapshots * fix all test for enzyme3 + react16 compat * Tests: Update react-pass-to-children to avoid spaces around children * Tests: Improve enzyme lazy loading before tests are triggered * Tests: Add snapshot serializer for enzyme wrapper * use adapter for r15 * shrinkwrap * 16-->15 fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
As part of
wp-calypso's upgrade to React 16, we need update Calypso's enzyme dependency to3.x. 3.0 comes with some breaking changes -- notably around the behavior of updates tomounted components, the usage ofrefs, and a few others.For the most part I was able to follow the lead of work done in gutenberg and the official migration docs.
Most of these commits were cherry-picked from the React 16 PR. Thank you @gziolo for cleaning up much of the test-harness code and also updating the snapshots to be 1% of their original size :). I was finally able to get the test suite to run in under 70 seconds!
Note: Between the 16 and 15 adapter there were 6 breaking tests. We'll need to add those fixes back in the 16 upgrade branch.