eslint: upgrade to 1.10.3

[blowery]

Move to 1.10.3 and 3.11.3 of the react plugin

To test, run make lint and it doesn't break

[sirbrillig]

Works for me! Should we fix the lint-reported errors in this PR also?

eg:

diff --git a/client/lib/preferences/test/actions.js b/client/lib/preferences/test/actions.js
index 730ffc4..55ea30a 100644
--- a/client/lib/preferences/test/actions.js
+++ b/client/lib/preferences/test/actions.js
@@ -98,7 +98,7 @@ describe( 'PreferencesActions', function() {
            } );
        } );

-       it( 'should not dispatch an empty local store', function() {
+       it( 'should not dispatch an empty local store', function( done ) {
            store.get.restore();
            sandbox.stub( store, 'get' ).returns( undefined );

[blowery]

Should we fix the lint-reported errors in this PR also?

Yes, have to, as they break the build. I was just pushing this up to track the breakage. Should have marked it In Progress, but ... yeah.

[sirbrillig]

I fixed a pile of them. The few remaining I'm not sure about (not sure how to use notices correctly since the refactor and I'm guessing maybe tinymce is global?).

[sirbrillig]

ping @codebykat for the tinymce errors:

/home/ubuntu/wp-calypso/client/components/tinymce/plugins/wpcom-charmap/charmap.jsx
  309:61  error  "tinymce" is not defined  no-undef

/home/ubuntu/wp-calypso/client/components/tinymce/plugins/wpcom-charmap/plugin.js
  49:2  error  "tinymce" is not defined  no-undef

[ehg]

tinymce is global

Yep. It's attached to the window object when the editor is loaded/pre-loaded.

[sirbrillig]

Ping @deBhal for the translator notices reference:

/home/ubuntu/wp-calypso/client/layout/community-translator/invitation-utils.js
  166:5  error  "notices" is not defined  no-undef

[nylen]

Fixed up the editor charmap in c415e0f. TinyMCE is a global but we shouldn't use it like that unless absolutely necessary.

[nylen]

The notices fix looked simple enough too (require( 'notices' ).error is used in lots of places).

I think this is good to go 👍

[sirbrillig]