Media: Hide edit button on private sites

[jeremeylduvall]

This is a temporary workaround to hide the Edit button on media items on private sites. It's related to #13625, which has received a few user reports. Right now, if you try to edit a media item in Calypso on a private site, you receive this error:

It's not clear why the edit action didn't work since you can edit media items in wp-admin.

My understanding (from this comment) is that this is a CORS limitation at the moment.

To test

1. On a private site, open the following URL with the branch loaded: http://calypso.localhost:3000/media/
2. Click on an item in your media library and then click the blue "Edit" button in the header

You should not see an edit button on the image. This should only affect private sites on WordPress.com.

Before

After

[matticbot]

Test live: https://calypso.live/?branch=fix/13625-hide-edit-button

[donnapep]

It looks like this will affect VideoPress videos as well. I'm guessing the same error applies in that scenario?

Also, if I've previously edited an image, I still see the "Restore Original" button although the "Edit Image" button is indeed removed. The image does restore when the button is clicked, so maybe it's fine to still show it:

[gwwar]

My understanding (from this comment) is that this is a CORS limitation at the moment.

That's correct!

I still see the "Restore Original" button although the "Edit Image" button is indeed removed.

We want to update this eventually but it does require some endpoint work. At the moment restore, adds another copy of the original as the latest edit instead of pointing at the original image. In this case the client doesn't have enough information to detect an, edit -> restore case.

[gwwar]

@retrofox do you recall if something changed recently? I thought we checked for this before.

[gwwar]

@jeremeylduvall this tests pretty well for me, unless other folks had feedback feel free to

[retrofox]

@retrofox do you recall if something changed recently? I thought we checked for this before.

I'm not aware of any recent change, Kerry. :-(

[gwwar]

@jeremeylduvall did you need help landing this one?

[jeremeylduvall]

@gwwar no - sorry! Will get this landed first thing tomorrow morning.