Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins: Don't display plugins for hidden sites on multiple sites views #1344

Closed
wants to merge 1 commit into from
Closed

Plugins: Don't display plugins for hidden sites on multiple sites views #1344

wants to merge 1 commit into from

Conversation

lezama
Copy link
Contributor

@lezama lezama commented Dec 7, 2015

how to test

Closes #820

@lezama lezama self-assigned this Dec 7, 2015
@lezama lezama added this to the Jetpack Plugin V2 - m2 - Plugins List view milestone Dec 7, 2015
@lezama lezama added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 7, 2015
mtias
mtias reviewed Dec 10, 2015
View reviewed changes
client/lib/plugins/store.js
sites.forEach( function( site ) {
var sitePlugins = PluginsStore.getSitePlugins( site );
sites.forEach( ( site ) => {
if ( sites.length > 1 && ! site.visible ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use sites.getVisible()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use this method in the site selected case too, in that case we want the list of plugins for that site even when the site is invisible.

@mtias mtias added [Status] Needs Author Reply and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 10, 2015
@lezama lezama added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Author Reply labels Dec 15, 2015
@enejb
Copy link
Member

enejb commented Dec 17, 2015

I think i fixed this in #1489.
2ed4c78

Feel free to iterate on the solution that I provided.

@enejb
Copy link
Member

enejb commented Dec 17, 2015

ping @lezama ^

@johnHackworth johnHackworth added [Status] Needs Author Reply and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 23, 2015
@jeherve jeherve mentioned this pull request Jan 8, 2016
Closed
@enejb enejb removed this from the Jetpack Plugin V2 - m2 - Plugins List view milestone Jan 29, 2016
@mtias
Copy link
Member

mtias commented Feb 12, 2016

@lezama what's the status of this one?

@lezama
Copy link
Contributor Author

lezama commented Feb 14, 2016

fixed, props @enejb #1489

@lezama lezama closed this Feb 14, 2016
@lezama lezama deleted the update/plugins-dont-fetch-for-invisible-sites branch February 14, 2016 21:51
@mtias
Copy link
Member

mtias commented Feb 15, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lezama lezama

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lezama @enejb @mtias @scruffian @johnHackworth