Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Invites: Ensure that user inputted data is decoded" #1250

Merged
merged 1 commit into from
Dec 3, 2015

Conversation

ebinnion
Copy link
Contributor

@ebinnion ebinnion commented Dec 3, 2015

Reverts #1222

All environments except for development seem to be broken. I believe it is related to my last pull request which modified user-bootstrap.

At this point, I'm not sure why this worked in development, but not in wpcalypso or staging. Pinging @ehg and @rralian who might be able to help out.

I'll keep digging.

@ebinnion ebinnion added the [Type] Bug When a feature is broken and / or not performing as intended label Dec 3, 2015
@ebinnion ebinnion self-assigned this Dec 3, 2015
ebinnion added a commit that referenced this pull request Dec 3, 2015
…-entities

Revert "Invites: Ensure that user inputted data is decoded"
@ebinnion ebinnion merged commit 6502dbc into master Dec 3, 2015
@ebinnion ebinnion deleted the revert-1222-fix/invites-html-entities branch December 3, 2015 23:11
@ebinnion
Copy link
Contributor Author

ebinnion commented Dec 4, 2015

@ehg commented in Slack that this was because shared/lib/formatting was including client/lib/warn, which isn't available on the server. This combined with the fact that users are bootstrapped when environment !== 'development' caused the error.

I have another PR that addresses the user object decoding started at #1257.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant