People: Invites: Redirect to /posts/%site% #1185
Conversation
lezama
added
[Type] Bug
| acceptInvite() { | ||
| const { invite } = this.props; | ||
| acceptInvite( invite, () => { | ||
| page( this.props.redirectTo ); |
There was a problem hiding this comment.
It doesn't look like we're doing any error handling here. I understand it's probably more edge case to handle errors here (since we validate an invite before showing the user this UI), but it is possible that a user is mobile and lost connection or somehow opened another tab and took an action which invalidated an invite.
In this case, we shouldn't redirect the user and tell him/her that it was successful.
|
I left a comment about error handling. In my testing, I am still getting redirected to |
| @@ -21,6 +22,14 @@ export default React.createClass( { | |||
|
|
|||
| displayName: 'InviteAcceptLoggedIn', | |||
|
|
|||
| acceptInvite() { | |||
There was a problem hiding this comment.
perhaps change this method name to simply accept
seeing acceptInvite written so close together feels a little confusing.
|
Closing this in favour of #1261 |
Fixes #1148
cc @ebinnion @roccotripaldi for an early review