Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Fixes post excerpt link going under the help icon #1103

Closed
wants to merge 4 commits into from
Closed

Reader: Fixes post excerpt link going under the help icon #1103

wants to merge 4 commits into from

Conversation

Kuzmanov
Copy link
Contributor

@Kuzmanov Kuzmanov commented Dec 1, 2015

Adds more padding from the right side so the text will not go underneath the help icon.

Issues #950 #709

@lancewillett lancewillett added [Feature] Reader The reader site on Calypso. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 1, 2015
@blowery
Copy link
Contributor

blowery commented Dec 1, 2015

Thanks for the PR @Kuzmanov! Would you mind rebasing this down to just the patch from 6981124? We like to keep pulls as focused as possible.

@blowery blowery added [Status] Needs Author Reply and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 1, 2015
@blowery
Copy link
Contributor

blowery commented Dec 1, 2015

Did the rebase myself (pulled this PR, then git fetch && git rebase -i origin/master and squashed everything down to one commit. Moved to #1154

@Kuzmanov
Copy link
Contributor Author

Kuzmanov commented Dec 1, 2015

Thanks @blowery. I tried, but obviously I was doing something wrong. Gotta learn more about using git through the command line :)

@blowery
Copy link
Contributor

blowery commented Dec 1, 2015

Yeah, squashing is a weird one. http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html is a pretty good intro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Reader The reader site on Calypso. OSS Citizen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants