Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Fix the graph timeframe when navigating to old periods #10968

Merged
merged 1 commit into from
Jan 27, 2017

Conversation

youknowriad
Copy link
Contributor

closes #10955

In this PR, I update the graph timeframe when navigating back to old periods. We make sure the selected date is always inside the graph timeframe.

Testing instructions

  • Go to `/stats/month (or /days or /weeks) and select a site if prompted.
  • Make sure the site select has more than a year (or more than 30 days) worth of stats.
  • Click the left arrow next to the main heading on the page until you navigate past the first bar on the left side of the graph.
  • The chart timeframe should update correctly. The selected date should still be visible on the chart (orange bar)

@youknowriad youknowriad added [Feature] Stats Everything related to our analytics product at /stats/ [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Bug When a feature is broken and / or not performing as intended labels Jan 26, 2017
@youknowriad youknowriad self-assigned this Jan 26, 2017
@matticbot
Copy link
Contributor

Copy link
Contributor

@timmyc timmyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice - this is a great addition being able to scroll back in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/ [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stats: graph timeframe does not update when viewing historical stats
3 participants