Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: Emojis as Square Blocks #29831

Closed
Aurorum opened this issue Jan 1, 2019 · 11 comments
Closed

Gutenberg: Emojis as Square Blocks #29831

Aurorum opened this issue Jan 1, 2019 · 11 comments
Labels
[Closed] Not Reproducible Issue cannot be reproduced. [Feature] Post/Page Editor The editor for editing posts and pages. [Goal] Gutenberg Working towards full integration with Gutenberg OSS Citizen [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@Aurorum
Copy link
Contributor

Aurorum commented Jan 1, 2019

Depending on how up to date a person's device is some folks can only see some unicode sets. Unsupported emoji characters are rendered as blocks. In the edit view, let's make sure to replace emoji with visual image placeholders like we do in the published view. See also #29831 (comment)

Steps to reproduce

  1. Starting at URL: https://wordpress.com/block-editor/post or /wp-admin/post.php
  2. Visit a site such as https://getemoji.com (one recommended here)
  3. Copy and paste a less common but still frequently used emoji (basically pretty much anything other than a smiley face)
  4. Enter it an a post

What I expected

The classic editors displays the emoji itself.

gfdsgfdsgfsdfs

gfsdfdsgfdsgfdgs

Starting at https://wordpress.org/gutenberg and following the same steps, the emoji will appear.

sgfdsgfdsdfgsfdg

What happened instead

fsgdfsdgfdsfdsg

gfsdfgsdgssdfg

Though very low priority (it's fine in the post), it'd be nice if emojis would appear as the emoji itself instead of a square box. Found this when writing my own posts.

@arunsathiya arunsathiya added [Status] Needs Author Reply [Goal] Gutenberg Working towards full integration with Gutenberg labels Jan 1, 2019
@arunsathiya
Copy link
Contributor

I am not able to reproduce this. When I copy from https://getemoji.com/ or https://emojipedia.org/, the emoji appears fine on the WordPress Editor.

Here is a video showing this behaviour.

Most often when emoji does not show as expected, and renders as a square, it means that your device does not support this emoji.

It's a bit strange because you are able to see this emoji on the Calypso editor, classic editor on /wp-admin but not on WordPress Editor.

What browser, which version of the browser and what operating system you are on at the moment?

@Aurorum
Copy link
Contributor Author

Aurorum commented Jan 1, 2019

It's odd, because I'm assuming my device doesn't support this emoji, although I'm fairly certain there's something which can be done for it to be seen. I've always assumed that because it works in the previous editors (and the Gutenberg one on wordpress.org) and other sites, such as Discord & Twitter - maybe I'm wrong though? Using a Mac OS X 10.6.8, running Chrome 49, but I didn't realise that this issue might be a case of your device/browser.

@arunsathiya arunsathiya added [Type] Bug When a feature is broken and / or not performing as intended and removed [Status] Needs Author Reply labels Jan 1, 2019
@arunsathiya
Copy link
Contributor

Yes, I am a bit surprised as well, as it appears fine on your Calypso editor amongst other editors you have mentioned. I am going to tag this for developers' attention to see if they have any thoughts.

@arunsathiya
Copy link
Contributor

@torres126 While we are discussing this, can you check if the common emoji appear fine on your WordPress Editor?

Can you also check if this is limited to https://wordpress.com/block-editor/post or does it happen on the WordPress Editor on the /wp-admin dashboard as well?

@arunsathiya arunsathiya added [Feature] Post/Page Editor The editor for editing posts and pages. Editor-Compatibility Formatting issues when saving to classic after gutenberg or vice versa labels Jan 1, 2019
@Aurorum
Copy link
Contributor Author

Aurorum commented Jan 1, 2019

Tested with a heart. And yep, I can still recreate from the /wp-admin Dashboard (see screenshot above).

sgfsfdsfdgsfdg
sdfgsfdgfdsg

@arunsathiya arunsathiya removed the Editor-Compatibility Formatting issues when saving to classic after gutenberg or vice versa label Jan 1, 2019
@gwwar
Copy link
Contributor

gwwar commented Jan 1, 2019

What's happening is that in the edit view is using the unicode characters directly, and the published view is replacing these with tweemoji images.

Edit View:
screen shot 2019-01-01 at 1 19 12 pm

Published:
screen shot 2019-01-01 at 1 23 46 pm

@torres126 how many of these can you see?
Unicode 6.1: 😀😗😙😑😮😯😴😛😕😟
Unicode 7.0: 🙂🙁🕵🗣🕴🖕🖖🖐
Unicode 8.0: 🤗🤓🤔🙄🤐🙃🤑🤒🤕🤖
Unicode 9.0: 🤣🤠🤡🤥🤤🤢🤧🤴🤶🤵🤷
Unicode 10.0: 🤩🤨🤯🤪🤬🤮🤫🤭🧐🧒
Unicode 11.0: 🥰🥾🦞🧬🧹🥭

The latest released set is: https://emojipedia.org/unicode-11.0/ and requires software updates. So likely the old Chrome version here is causing issues.

It looks like we are having some trouble with the Unicode 11 set in the published view, but that's better left as a new bug 🤔

screen shot 2019-01-01 at 1 21 36 pm

Next Steps:

  • See if we have similar behavior in Gutenberg core. If so, file an enhancement to replace with twemoji in the edit view. If this is custom to Calypso, we can update the summary and turn this into an enhancement
  • File an issue against the Unicode 11 set.

I'm happy to circle back to items noted here, but feel free to take on items if you'd like to help test/file.

@Aurorum
Copy link
Contributor Author

Aurorum commented Jan 2, 2019

@gwwar On GitHub directly on my (unsupported) computer, none. On my Android device, the top four rows. Here's some screenshots from my computer:

dhfghgdfgfhdgh-1
gfdsfgssdfgdsgf-1
gfdsgdsfdgdfsg-1

Since https://wordpress.org/gutenberg & https://wordpress.com/post displays all emojis fine, it'd be nice if the edit view used twemoji too.

From my understanding, Unicode 11 is only available on recent iOS devices currently. That being said, they load fine at both https://wordpress.org/gutenberg, but they don't load at all in Calypso (just square boxes, as shown above).

For comparison, here's Twitter, where I'm assuming all emojis would load fine regardless of device.

sgfddgfssgfdsd

I'm guessing therefore that there's an issue with the Unicode 11 set with Calypso (no issues when testing with Gutenberg at https://wordpress.org/gutenberg), so I'll file a separate issue for that. Edited: Done! #29866

@gwwar
Copy link
Contributor

gwwar commented Jan 2, 2019

Since https://wordpress.org/gutenberg & https://wordpress.com/post displays all emojis fine, it'd be nice if the edit view used twemoji too.

Thanks @torres126 ! Right it looks like core is using a different image emoji set but still has the same issue, that we don't replace the unicode in the edit view, which may display squares for some folks.

screen shot 2019-01-02 at 12 47 08 pm

screen shot 2019-01-02 at 12 47 41 pm

I'll go ahead and update the summary of this one to indicate the edit case for Calypso, and I think we have an open one here for Gutenberg core:
WordPress/gutenberg#7440

@gwwar gwwar added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it and removed [Type] Bug When a feature is broken and / or not performing as intended labels Jan 2, 2019
@Aurorum
Copy link
Contributor Author

Aurorum commented Feb 22, 2019

Possible (still confirming if its a WPcom site but it's in the WPcom forums) mention here: https://en.forums.wordpress.com/topic/unable-to-copy-past-unicode-in-gutenberg
not related

@Portekoi
Copy link

I'm the author of this post. Since the update to Gutenberg, copy/past emoticons stop working.

@worldomonation
Copy link
Contributor

Hi! I'm performing triage on older bugs as part of Quality Squad's efforts to cut down on backlog issue counts.

I was able to verify that emojis work in the title and body blocks of both posts and pages.

As there has been no recent activity on this issue, the issue is being closed with the label Closed - Not Reproducible.
If work is scoped and tabled for a milestone, please feel free to re-open this bug.

@worldomonation worldomonation added the [Closed] Not Reproducible Issue cannot be reproduced. label Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Closed] Not Reproducible Issue cannot be reproduced. [Feature] Post/Page Editor The editor for editing posts and pages. [Goal] Gutenberg Working towards full integration with Gutenberg OSS Citizen [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

5 participants