Merge pull request #6543 from Automattic/update/eslint-config-external

Framework: Update ESLint configuration to extend shared config

.eslintrc.js

@@ -1,127 +1,86 @@
-/* eslint-disable quote-props */
 module.exports = {
 	root: true,
+	'extends': 'wpcalypso/react',
 	parser: 'babel-eslint',
 	env: {
 		browser: true,
-		es6: true,
 		mocha: true,
 		node: true
 	},
-	parserOptions: {
-		ecmaVersion: 6,
-		ecmaFeatures: {
-			jsx: true
-		},
-		sourceType: 'module'
-	},
-	plugins: [
-		'eslint-plugin-react',
-		'eslint-plugin-wpcalypso'
-	],
+	// Ideally, we should not have a `rules` block here at all, save for some
+	// Calypso-specific rules (no-unused-expressions, camelcase). The remainder
+	// are rules we cannot yet flag as errors, and should be removed over time
+	// as outstanding issues are resolved.
 	rules: {
 		'array-bracket-spacing': [ 1, 'always' ],
 		'brace-style': [ 1, '1tbs' ],
 		// REST API objects include underscores
-		'camelcase': 0,
-		'comma-dangle': 0,
+		camelcase: 0,
 		'comma-spacing': 1,
-		'comma-style': 2,
-		'computed-property-spacing': [ 1, 'always' ],
-		'constructor-super': 2,
-		// Allows returning early as undefined
-		'consistent-return': 0,
-		'curly': 1,
+		curly: 1,
 		'dot-notation': 1,
-		'eqeqeq': [ 2, 'allow-null' ],
+		'computed-property-spacing': [ 1, 'always' ],
 		'eol-last': 1,
-		'indent': [ 1, 'tab', { 'SwitchCase': 1 } ],
+		indent: [ 1, 'tab', { SwitchCase: 1 } ],
 		'jsx-quotes': [ 1, 'prefer-double' ],
 		'key-spacing': 1,
 		'keyword-spacing': 1,
 		'max-len': [ 1, { code: 140 } ],
-		'new-cap': [ 1, { 'capIsNew': false, 'newIsCap': true } ],
-		'no-cond-assign': 2,
-		'no-const-assign': 2,
+		'new-cap': [ 1, { capIsNew: false, newIsCap: true } ],
 		'no-console': 1,
-		'no-debugger': 2,
-		'no-dupe-args': 2,
-		'no-dupe-keys': 2,
-		'no-duplicate-case': 2,
 		'no-else-return': 1,
-		'no-empty': [ 2, { allowEmptyCatch: true } ],
 		'no-extra-semi': 1,
-		// Flux stores use switch case fallthrough
-		'no-fallthrough': 0,
 		'no-lonely-if': 1,
-		'no-mixed-requires': 0,
 		'no-mixed-spaces-and-tabs': 1,
 		'no-multiple-empty-lines': [ 1, { max: 1 } ],
 		'no-multi-spaces': 1,
-		'no-negated-in-lhs': 2,
 		'no-nested-ternary': 1,
 		'no-new': 1,
 		'no-process-exit': 1,
 		'no-redeclare': 1,
 		'no-shadow': 1,
 		'no-spaced-func': 1,
 		'no-trailing-spaces': 1,
-		'no-undef': 2,
-		'no-underscore-dangle': 0,
 		'no-unreachable': 1,
 		// Allows Chai `expect` expressions
 		'no-unused-expressions': 0,
 		'no-unused-vars': 1,
-		// Allows function use before declaration
-		'no-use-before-define': [ 2, 'nofunc' ],
 		'no-var': 1,
 		'object-curly-spacing': [ 1, 'always' ],
-		// We split external, internal, module variables
-		'one-var': 0,
-		'operator-linebreak': [ 1, 'after', { 'overrides': {
+		'operator-linebreak': [ 1, 'after', { overrides: {
 			'?': 'before',
 			':': 'before'
 		} } ],
 		'padded-blocks': [ 1, 'never' ],
 		'prefer-const': 1,
-		'quote-props': [ 1, 'as-needed', { 'keywords': true } ],
-		'quotes': [ 1, 'single', 'avoid-escape' ],
-		// Teach eslint about React+JSX
+		'quote-props': [ 1, 'as-needed', { keywords: true } ],
+		quotes: [ 1, 'single', 'avoid-escape' ],
 		'react/jsx-uses-react': 1,
 		'react/jsx-uses-vars': 1,
-		'react/jsx-no-undef': 2,
 		'react/jsx-no-duplicate-props': 1,
-		'react/react-in-jsx-scope': 2,
-		'react/no-danger': 2,
 		'react/no-did-mount-set-state': 1,
 		'react/no-did-update-set-state': 1,
 		'react/no-is-mounted': 1,
 		'react/jsx-no-bind': 1,
 		'react/jsx-curly-spacing': [ 1, 'always' ],
-		'semi': 1,
+		semi: 1,
 		'semi-spacing': 1,
 		'space-before-blocks': [ 1, 'always' ],
 		'space-before-function-paren': [ 1, 'never' ],
 		'space-in-parens': [ 1, 'always' ],
-		'space-infix-ops': [ 1, { 'int32Hint': false } ],
+		'space-infix-ops': [ 1, { int32Hint: false } ],
 		'space-unary-ops': [ 1, {
 			overrides: {
 				'!': true
 			}
 		} ],
-		// Assumed by default with Babel
-		'strict': [ 2, 'never' ],
-		'valid-jsdoc': [ 1, { 'requireReturn': false } ],
-		// Common top-of-file requires, expressions between external, interal
-		'vars-on-top': 1,
-		// Custom rules
+		'valid-jsdoc': [ 1, { requireReturn: false } ],
 		'wpcalypso/i18n-ellipsis': 1,
 		'wpcalypso/i18n-no-variables': 1,
 		'wpcalypso/i18n-no-placeholders-only': 1,
 		'wpcalypso/i18n-mismatched-placeholders': 1,
 		'wpcalypso/i18n-named-placeholders': 1,
 		'wpcalypso/jsx-gridicon-size': 1,
 		'wpcalypso/jsx-classname-namespace': 1,
-		'yoda': 0
 	}
 };

package.json

@@ -156,6 +156,7 @@
     "esformatter-semicolons": "1.1.1",
     "esformatter-special-bangs": "1.0.1",
     "eslint": "2.13.1",
+    "eslint-config-wpcalypso": "0.2.0",
     "eslint-plugin-react": "5.2.2",
     "eslint-plugin-wpcalypso": "1.3.3",
     "glob": "7.0.3",