Editor: Fix Pages always being marked as dirty (#6866)

This effectively reverts 0556ad0 where the bug was introduced.
Automattic · Jul 18, 2016 · 1913d28 · 1913d28
1 parent ca92df0
commit 1913d28
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/client/state/posts/selectors.js b/client/state/posts/selectors.js
@@ -342,6 +342,10 @@ export const isEditedPostDirty = createSelector(
 		const edits = getPostEdits( state, siteId, postId );
 
 		return some( edits, ( value, key ) => {
+			if ( key === 'type' ) {
+				return false;
+			}
+
 			if ( post ) {
 				return post[ key ] !== value;
 			}

diff --git a/client/state/posts/test/selectors.js b/client/state/posts/test/selectors.js
@@ -933,7 +933,7 @@ describe( 'selectors', () => {
 			expect( isDirty ).to.be.false;
 		} );
 
-		it( 'should return true if newly edited with custom type', () => {
+		it( 'should return false if newly edited with custom type', () => {
 			const isDirty = isEditedPostDirty( {
 				posts: {
 					items: {},
@@ -947,7 +947,7 @@ describe( 'selectors', () => {
 				}
 			}, 2916284 );
 
-			expect( isDirty ).to.be.true;
+			expect( isDirty ).to.be.false;
 		} );
 
 		it( 'should return false if no saved post and value matches default for new post', () => {