Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile updates should send the full actor object #1203

Open
mattwiebe opened this issue Jan 23, 2025 · 1 comment
Open

Profile updates should send the full actor object #1203

mattwiebe opened this issue Jan 23, 2025 · 1 comment
Assignees
Labels

Comments

@mattwiebe
Copy link
Contributor

Quick summary

Reported by @snarfed in akirk/friends#436


I noticed an interesting quirk of the Update AP activities for actors that Friends sends out: they don't include the complete new actor object, just the id. eg something like:

{
  "@context": ["https://www.w3.org/ns/activitystreams"],
  "type": "Update",
  "id": "https://cmalt.simonwood.info/@blog#activity-update-1737411556",
  "actor": "https://cmalt.simonwood.info/@blog",
  "object": "https://cmalt.simonwood.info/@blog",
  "to": "https://www.w3.org/ns/activitystreams#Public"
}

Technically AP says S2S Updates should include the complete object (more):

Server to server interaction and updates from the server to the client should contain the entire new representation of the object...

Steps to reproduce

Update your profile and log the output. This is where a real outbox will come in handy, we can inspect things there. :)

Site owner impact

More than 60% of the total website/platform users

Severity

Minor

What other impact(s) does this issue have?

No response

If a workaround is available, please outline it here.

No response

@mattwiebe
Copy link
Contributor Author

mattwiebe commented Jan 23, 2025

This, as mentioned by @pfefferle in this comment, will actually be fixed in our new Outbox system that will land in #1203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant