Reporting: Preset date range selector for payment gateway widget #8910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +610 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
6 tasks
added 2 commits
June 6, 2024 13:00
…te-selector-for-payment-widget
nagpai
changed the title
jessy-p
requested changes
Jun 6, 2024
There was a problem hiding this comment.
While we can integrate the selector implemented as part of #8896 in a separate PR, can we align this PR to the design more closely?
At present this PR appears to have two components, a selector and a label
Many date related functions and logic have been added to the Payment Activity Component.
Could we instead have a single selector component with the following options:
- Today: June 6, 2024
- Last 7 days: May 30 - June 5, 2024
- Last 4 weeks: May 9 - June 5, 2024
- Last 3 months: March 6 - June 5, 2024
- Last 12 months: June 6, 2023 - June 5, 2024
- Month to date: June 1 - June 6, 2024
- Quarter to date: April 1 - June 6, 2024
- Year to date: January 1 - June 6, 2024
- All time: Jan 1, 2024 - June 6, 2024
i.e.
Figma Design:
In this PR we could do it this way:
All date related functionality should be encapsulated in the date related component.
Using the selector from #8896 can be added in a separate PR.
haszari
added
the
status: blocked
|
Marking blocked, I think we're getting bogged down here and should focus on merging ⇒ adopting the new component (e.g. rework this PR or start new PR). |
|
We'll need a tracks event for when user changes the time period. Here's my proposal:
Feel free to iterate on the name & props, and update the registration if needed. I have work-in-progress event name & props in registration repo. |
|
Closing in favor of #8927 , where we have reworked and implemented this using the new |
|
Closing this in favor of #8927 |
nagpai
removed
the
status: blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #8734
Changes proposed in this Pull Request
What is not covered
Testing instructions
_wcpay_feature_payment_overview_widgetis enabledTodayshould show only today's date and no end date ( check screenshot )Last 12 months- It should show the year on both start and end date, since the years are differentScreenshots
Today
Different year for start and end
Same year for start and end
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge