Reorganise payments overview currency switcher, welcome message and balances card #8791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +1.43 kB (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Jinksi
changed the base branch from
develop
to
add/8788-select-component-for-currency-switcher
…pdate/8765-payments-overview-currency-select
…pdate/8765-payments-overview-currency-select
6 tasks
…ence from `CustomSelectControl`
…pdate/8765-payments-overview-currency-select
Base automatically changed from
add/8788-select-component-for-currency-switcher
to
develop
June 7, 2024 04:13
|
I'll fix a PW e2e test had I've inadvertently broken with these changes ✅ Fixed in c6da1bf |
|
Minor - On the mobile view, the currency switcher appears on top of the greeting and the spacing seems a bit non uniform / awkward. It may need some design input . The center alignment seems off a bit too.
|
dalakatt
approved these changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8790
Important
This pull request is based on PR #8896 to use the new select component introduced in that PR. Please merge it to
developbefore merging this PR.Caution
These changes are not behind a feature flag.
Changes proposed in this Pull Request
This PR replaces the Payments Overview currency-switching tabs with a new currency selector dropdown.
View design.
Note
A subsequent issue #8490 will handle the Payments Activity Card currency-switching, which is not part of this PR
currency.select.component.demo.mov
Before/After
Before
After
After – stores with a single deposit currency
TODO
_changeto clarify merchant intentTesting instructions
Tip
This PR is currently available to test on the Helix WooExpress demo site. Ask a team Helix member for access.
wcpay_overview_currency_select_changeis recordedselected_currencyquery param reflects the currently selected currencyselected_currencyquery param from the URL and navigate to it. Ensure the default deposit currency is then selected.selected_currencyquery param to the URL (e.g.selected_currency=123) and navigate to it. Ensure the default deposit currency is then selected.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge
wcpay_overview_currency_select_changehttps://github.com/Automattic/tracks-events-registration/pull/2467wcpay_overview_balances_currency_tab_clickhttps://github.com/Automattic/tracks-events-registration/pull/2467