Valet Theme Updater — Token Transformer #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vip-design-system-components ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
djalmaaraujo
force-pushed
the
add/theme-updater-for-valet
branch
from
d11991b
to
4c79d2a
Compare
djalmaaraujo
force-pushed
the
add/theme-updater-for-valet
branch
from
4c79d2a
to
7100190
Compare
luiztiago
reviewed
Jul 21, 2022
| @@ -56,7 +56,7 @@ const outline = { | |||
| outlineStyle: 'solid', | |||
| outlineColor: '#ffffff', | |||
| outlineWidth: '1px', | |||
| boxShadow: `0 0 0 1px #fff, 0 0 0 3px ${ getColor( 'focus' ) }`, | |||
| boxShadow: `0 0 0 1px ${ getColor( 'focus', 'inset' ) }, 0 0 0 3px ${ getColor( 'focus' ) }`, | |||
|
LGTM |
luiztiago
approved these changes
Jul 21, 2022
alecgeatches
approved these changes
Jul 22, 2022
Yes, that's the idea for future improvements @alecgeatches 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing a way to have the VIP Design System (Figma files) integrated with all our React components 🥳 . The long explanation is described in the README.md file changes in this Pull Request.
The long history short is: We now can read all theming information we need from a tokens JSON file and parse it so the React theme can be read and used in the components system.
New npm script command added:
Checklist
Steps to Test
npm run theme-update.src/generated/valet-theme.jsonfilenpm run dev