Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/alert role to notifications and ScreenReaderText #70

Merged
merged 5 commits into from
Jun 30, 2022

Conversation

djalmaaraujo
Copy link
Contributor

@djalmaaraujo djalmaaraujo commented Jun 29, 2022

Description

  • New proposal for Notification.

We are adding the role="alert" to the Notification component when it appears. It will not focus on the element.

image

image

  • Adding ScreenReaderText component for easy screen-reader-text class access

Checklist

  • This PR has good automated test coverage
  • The storybook for the component has been updated

Steps to Test

  1. Pull down PR.
  2. npm run dev.
  3. Activate voice over (cmd+fn+f5 on macOS)
  4. Open http://localhost:6006/?path=/story/notification--default
  5. You should listen: Alert, Awesome! Your message has been sent successfully.

@netlify
Copy link

netlify bot commented Jun 29, 2022

Deploy Preview for vip-design-system-components ready!

Name Link
🔨 Latest commit 5af1581
🔍 Latest deploy log https://app.netlify.com/sites/vip-design-system-components/deploys/62bcbbabfe493c00088b8eaa
😎 Deploy Preview https://deploy-preview-70--vip-design-system-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@djalmaaraujo djalmaaraujo changed the title Add/alert role to notifications Add/alert role to notifications and ScreenReaderText Jun 29, 2022
@djalmaaraujo djalmaaraujo requested a review from a team June 29, 2022 20:54
Copy link
Contributor

@brunobasto brunobasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and sounds good to me. Thank you for improving this!

Only minor comment would be about the translation of the word Alert, but we can think about that in the future.

🚢

@djalmaaraujo
Copy link
Contributor Author

Tested and sounds good to me. Thank you for improving this!

Only minor comment would be about the translation of the word Alert, but we can think about that in the future.

🚢

Good point. We are not using any internalization here.

@djalmaaraujo djalmaaraujo merged commit bd3dcff into trunk Jun 30, 2022
@djalmaaraujo djalmaaraujo deleted the add/alert-role-to-notifications branch June 30, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants