Revamp Radio Component with A11Y #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vip-design-system-components ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
djalmaaraujo
force-pushed
the
fix/radio-button-click
branch
2 times, most recently
from
541eee6
to
c900483
Compare
|
Thanks for the classes on each item, @djalmaaraujo |
brunobasto
approved these changes
Nov 24, 2022
src/system/Form/Radio.js
Outdated
| { disabled, defaultValue, onChange, name = '', options = [], className, ...props }, | ||
| forwardRef | ||
| ) => { | ||
| const renderedOptions = useMemo( |
There was a problem hiding this comment.
@djalmaaraujo I wonder if the overhead of useMemo is beneficial here. I would guess the options array will likely be small (< 5), and I don't see any heavy processing happening inside the loop.
There was a problem hiding this comment.
@brunobasto Might not be that much, indeed. The main reason I added it is because, usually, people do onChange with an inline-function. The parent will make this component re-render often, mainly because it's a form with many interactions.
| as="label" | ||
| sx={ { display: 'block', mb: 2, color: 'muted' } } | ||
| const Label = React.forwardRef( ( { sx, ...rest }, forwardRef ) => ( | ||
| <label |
djalmaaraujo
force-pushed
the
fix/radio-button-click
branch
from
9bebd25
to
9cfedda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are revamping the
Radiocomponent. Radio components only make sense to be used with two or more. That's the nature of Radios; you need two or more options.The current implementation lets you choose only one Radio button. In this new implementation, you must pass an array of options (similar to other components). This will provide more clarity and avoid forms with one radio button, and this new implementation is accessible.
BREAKING CHANGE: The new implementation of the
<Radio>will break current usage. Once you upgrade this component, you need to change the implementation. Follow the Storybook story to understand the new API.Checklist
Steps to Test
npm run dev.