Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archeo: Try new root padding alignments #6312

Merged
merged 2 commits into from
Aug 5, 2022
Merged

Conversation

scruffian
Copy link
Member

@scruffian scruffian commented Aug 3, 2022

Changes proposed in this Pull Request:

This tries implementing the root padding alignment rules proposed in WordPress/gutenberg#42085. This means we can remove the alignment CSS.

Comparison

Before: After:
before after

Related issue(s):

WordPress/gutenberg#42085

@scruffian scruffian self-assigned this Aug 3, 2022
@scruffian scruffian requested a review from mikachan August 3, 2022 16:59
@scruffian scruffian added the [Theme] Archeo Automatically generated label for Archeo. label Aug 3, 2022
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the new root padding alignments are working in most cases, apart from blocks nested in a full-width group block:

This PR:
image

Trunk (with alignment CSS & no root padding set):
image

@scruffian
Copy link
Member Author

I'm not sure that the behaviour in trunk is desirable anyway, I think this is a fair compromise.

@mikachan
Copy link
Member

mikachan commented Aug 4, 2022

Ah OK, I guess I was basing the intended gap on the wording in this test markup ('should have a gap between it and the edge'), and it seemed to be one of the biggest differences from the previous behaviour.

If these current gaps aren't ideal (and I would assume 'full width' should have no gaps between the container and the edge anyway) then the root padding seems to be working well 👍

@MaggieCabrera
Copy link
Contributor

It looks like this will need some adjustments in Archeo, the text in the home page is not aligned anymore:

Before After
Screenshot 2022-08-05 at 10 21 19 Screenshot 2022-08-05 at 10 21 14

@scruffian
Copy link
Member Author

Good catch, thanks. I've zeroed some of the paddings here so that they match:
Screenshot 2022-08-05 at 15 08 32

Copy link
Contributor

@vcanales vcanales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM 🚢

@scruffian scruffian merged commit 9d0b852 into trunk Aug 5, 2022
@scruffian scruffian deleted the try/alignment-style-archeo branch August 5, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Theme] Archeo Automatically generated label for Archeo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants