-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Archeo: Try new root padding alignments #6312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that the behaviour in trunk is desirable anyway, I think this is a fair compromise. |
Ah OK, I guess I was basing the intended gap on the wording in this test markup ('should have a gap between it and the edge'), and it seemed to be one of the biggest differences from the previous behaviour. If these current gaps aren't ideal (and I would assume 'full width' should have no gaps between the container and the edge anyway) then the root padding seems to be working well 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM 🚢
Changes proposed in this Pull Request:
This tries implementing the root padding alignment rules proposed in WordPress/gutenberg#42085. This means we can remove the alignment CSS.
Comparison
Related issue(s):
WordPress/gutenberg#42085