Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block canvas: comment block #6109

Merged
merged 3 commits into from
Jun 30, 2022
Merged

Block canvas: comment block #6109

merged 3 commits into from
Jun 30, 2022

Conversation

MaggieCabrera
Copy link
Contributor

@MaggieCabrera MaggieCabrera commented Jun 22, 2022 •
edited
Loading

This replicates the changes done on Blockbase in #5833 to Block Canvas as well so our new themes use the new block too

Edit: I rebased to pick up the Block canvas fixes and this is what it looks like

Before After
Screenshot 2022-06-23 at 16-36-58 Hello world! – maggie Screenshot 2022-06-23 at 16-37-15 Hello world! – maggie

@MaggieCabrera
Copy link
Contributor Author

I haven't added screenshots because I found some bugs in Block Canvas that I'll be fixing in a follow up PR

@MaggieCabrera MaggieCabrera self-assigned this Jun 22, 2022
@MaggieCabrera MaggieCabrera mentioned this pull request Jun 22, 2022
Merged
@MaggieCabrera MaggieCabrera requested a review from a team June 23, 2022 14:38
@MaggieCabrera MaggieCabrera marked this pull request as ready for review June 23, 2022 14:38
@MaggieCabrera MaggieCabrera mentioned this pull request Jun 28, 2022
Closed
madhusudhand
madhusudhand reviewed Jun 28, 2022
View reviewed changes
Copy link
Member

@madhusudhand madhusudhand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Font size slightly increased for the comment author, comment date and reply link from 15.75px => 18px in comments block, where as other links such as post category and post date are at 14px.
We will have to bring both to same size.

Everything else LGTM!

@MaggieCabrera MaggieCabrera force-pushed the block-canvas-comments branch from 9ae8c58 to 8a4d193 Compare June 30, 2022 11:31
@MaggieCabrera
Copy link
Contributor Author

Font size slightly increased for the comment author, comment date and reply link from 15.75px => 18px in comments block, where as other links such as post category and post date are at 14px. We will have to bring both to same size.

Everything else LGTM!

Great catch! I was using the same variables as Blockbase and those weren't working. Bad copy paste, bad!

@MaggieCabrera MaggieCabrera requested a review from a team June 30, 2022 11:31
@MaggieCabrera
Copy link
Contributor Author

This just needs a green check, should be good to go

mikachan
mikachan approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, and the latest changes fix @madhusudhand's comment ✅

@MaggieCabrera MaggieCabrera merged commit 83f4768 into trunk Jun 30, 2022
@scruffian scruffian deleted the block-canvas-comments branch June 30, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madhusudhand madhusudhand madhusudhand left review comments

@mikachan mikachan mikachan approved these changes

Assignees

@MaggieCabrera MaggieCabrera

Labels
[Theme] Block Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaggieCabrera @mikachan @madhusudhand