Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stewart: refactor patterns #5854

Merged
merged 5 commits into from
Apr 20, 2022
Merged

Stewart: refactor patterns #5854

merged 5 commits into from
Apr 20, 2022

Conversation

matiasbenedetto
Copy link
Member

Changes proposed in this Pull Request:

Stewart: refactor patterns following the latest Gutenberg changes

Related issue(s):

#5803

@matiasbenedetto matiasbenedetto mentioned this pull request Apr 12, 2022
Closed
4 tasks
@pbking
Copy link
Contributor

pbking commented Apr 13, 2022

Looks like most of the titles (but not all) had 'block pattern' appended to them (and shouldn't). Also the header patterns should have the block type added to the metadata.

The actually implementation looks solid though, I didn't notice any discrepancies there.

Just need to fix up some of the metadata.

@matiasbenedetto
Copy link
Member Author

The small fixes pointed out by @pbking were solved.
Thanks for the review!

@matiasbenedetto matiasbenedetto requested a review from pbking April 19, 2022 14:59
mikachan
mikachan approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all @pbking's comments have been addressed. LGTM! 🚢

@mikachan mikachan merged commit 5ecdf00 into trunk Apr 20, 2022
@mikachan mikachan deleted the update/stewart-patterns-refactor branch April 20, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikachan mikachan mikachan approved these changes

@pbking pbking Awaiting requested review from pbking

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matiasbenedetto @pbking @mikachan