Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pendant/templates/page-about.html to meet the design suggested … #5759

Closed

Conversation

PeterNdomano
Copy link
Contributor

Changes proposed in this Pull Request:

Added and edited pendant/templates/page-about.html to meet the design suggested in #5745

Related issue(s):

#5745

About page look after applying above changes

Screenshot 2022-03-27 at 00-39-01 About My Sandbox – My WP-Sandbox

@pbking

@pbking
Copy link
Contributor

pbking commented Mar 28, 2022

A solid start.

Check out how the layout is structured in this continuation of your other pull request. We can achieve edge-less (when needed) layout elements to make sure the gaps are only where we want them to be.

Also, while I work this project I'm testing the workflow of editing the templates with the FSE and "saving" the work using the Create Block Theme plugin.

If you're able to evaluate that while working on this (or other) themes your input would be appreciated.

@PeterNdomano
Copy link
Contributor Author

Thanks @pbking I had a look and understood what you meant.

Also previously I wasn't using 'Create Block Theme' plugin but I'll start using it as soon as possible so expect my contribution on it too.

@PeterNdomano PeterNdomano deleted the pendant-theme-about-page branch June 14, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants