Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block canvas and pendant: fixed block patterns #5713

Merged
merged 3 commits into from
Mar 22, 2022

Conversation

MaggieCabrera
Copy link
Contributor

Changes proposed in this Pull Request:

This PR includes the latest changes from WordPress/gutenberg#36751. That has been merged now so the patterns should work with GB trunk.

@MaggieCabrera MaggieCabrera requested a review from a team March 21, 2022 09:42
@MaggieCabrera MaggieCabrera self-assigned this Mar 21, 2022
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are both working great for me with the latest GB trunk.

@mikachan
Copy link
Member

I think this should wait to be merged until GB 12.9 is available on dotcom.

@pbking
Copy link
Contributor

pbking commented Mar 22, 2022

I think that Block Canvas (and pendant) are already committed to GB 12.9+. I think we should go ahead and merge these in and ensure that neither of those themes are released to dotcom until 12.9 lands.

@pbking pbking merged commit 18482fa into trunk Mar 22, 2022
@pbking pbking deleted the fix-patterns-block-canvas-pendant branch March 22, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants