Archeo: Add Image with description pattern #5479
Conversation
| <!-- /wp:separator --> | ||
|
|
||
| <!-- wp:paragraph --> | ||
| <p>' . __( 'Ancien Temple, à Chichen-Itza, applé le chateau', 'archeo' ) ) . '</p> |
There was a problem hiding this comment.
@kjellr can we replace this with an English string?
There was a problem hiding this comment.
We've got French Strings throughout actually. They're pulled directly from the image descriptions here:
https://digitalcollections.nypl.org/items/510d47db-11e9-a3d9-e040-e00a18064a99
At first I was into keeping them, but now that I'm thinking about it more I'm not totally sure. It seems a little weird to keep it in french. For now, I think we should just use this as is. But once all the patterns are implemented I can do a sweep through them all and replace the strings. We use the same images in multiple patterns, and that way we can make sure the strings are all consistent.
There was a problem hiding this comment.
Created an issue for this here: #5485
|
I fixed an issue with an extra ) |
Thanks.. bad copying and pasting from me! I've created an issue for the string replacement, for when all the patterns are finished: #5484 |
Changes proposed in this Pull Request:
This adds the 'Image with description' pattern to Archeo.
I don't think we can adjust the size of the separator until there's a fix for this: WordPress/gutenberg#34638
Related issue(s):
#5429