Blockbase: replace user key with custom #5147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
approved these changes
Dec 6, 2021
|
When 12.1 launches on wpcom we need to launch this ASAP |
|
We might want to change the approach here so that it can work before 12.1 launches. |
|
I pushed a change that will allow this to work with both 12.0 and 12.1. Tested with first 12.0 and then upgraded Gutenberg to 12.1 and evaluated the same setup. |
mikachan
commented
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR replaces the
userorigin key withcustom, from this GB PR: WordPress/gutenberg#36748.To test, make sure you're using at least GB 12.1, and change the color and fonts of Blockbase in the Customizer. Without this change, these settings will be overwritten/reverted when leaving or refreshing the Customizer. With this change, these settings should save correctly.
I couldn't find any references to the
corekey, which we should change todefault(from this PR: WordPress/gutenberg#36645), and as the color and font customizations seem to be working with the above, I'm hoping it's only theuserkey we need to change.Related issue(s):
Closes #5077