Skatepark: apply wide width to header #4464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jffng
force-pushed
the
fix/skatepark-header
branch
from
3d71ae6 to
cfab582
Compare
jffng
commented
Aug 24, 2021
pbking
approved these changes
Aug 24, 2021
There was a problem hiding this comment.
This looks OK.
I think we could do the same with another group wrapping the header. I don't believe either is wrong but wrapping with a "full width" group would be "reproducable" in the template editor. With the state of flex controls (currently lacking) I don't think that matters now. Once flex is more powerful this will need to be changed again then and can be re-evaluated then.
melchoyce
approved these changes
Aug 24, 2021
I opened a PR to try that idea #4466, it works but yeah I'm not sure which one is preferred. Going to merge this one for now to get the design in place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR adds some styles to ensure the Skatepark header does not extend beyond the wide width. Now that #4459 has merged, this is ready for a review.
Related issue(s):
Closes #4407