Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varia: Fix button styles to work alongside Gutenberg 7.9 #1925

Merged
merged 4 commits into from
Apr 17, 2020

Conversation

kjellr
Copy link
Contributor

@kjellr kjellr commented Apr 16, 2020

This PR updates the button style editor styles so that they work alongside Gutenberg 7.9. That release changed the button markup, and now the .wp-block-button__link class is applied on the same element as .wp-block-button.

To test, please make sure you're running Gutenberg 7.9. This PR is essentially a mirror of Automattic/themes-workspace#75.

--

Before:

Screen Shot 2020-04-16 at 7 41 25 PM

After:

Screen Shot 2020-04-16 at 7 41 15 PM

@@ -1439,6 +1439,10 @@ button[data-load-more-btn], .button {
padding: 14px 16px;
}

.wp-block-button.is-style-outline .wp-block-button__link:active {
Copy link
Contributor Author

@kjellr kjellr Apr 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an uncompiled remnant from a previous commit? These changes shouldn't actually touch this file.

@allancole
Copy link
Contributor

So this is a bit more complex than I had thought. I’m still gonna merge and deploy this for the visual fix, but floating in the editor on Button Blocks created before 7.9 isn’t working so well. Filed an issue for it here: WordPress/gutenberg#21685

Copy link
Contributor

@allancole allancole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few changes to make sure the new outline Block style works properly. Also cleans up the alignment classes so that “legacy” Button blocks float properly on the front end. The back end needs to be fixed in the Gutenberg plugin as per this issue: WordPress/gutenberg#21685

@allancole
Copy link
Contributor

Gonna go ahead and merge this along with #1927 right after 👍

@allancole allancole merged commit 57d3d21 into master Apr 17, 2020
@kjellr kjellr deleted the fix/varya-button-styles branch April 20, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants