Skip to content
This repository has been archived by the owner on Feb 17, 2025. It is now read-only.

Illustratr: Replace window.load event with document.ready #114

Merged
merged 1 commit into from
May 3, 2018

Conversation

laurelfulford
Copy link
Contributor

Replace $(window).load() event with $(document).ready() for functions that show hidden elements on the page, to help work around ads issue.

Related issue(s):

See #108

…ns that show hidden elements on the page, to help work around ads issue. See #108.
@laurelfulford
Copy link
Contributor Author

This one still needs work; I missed a couple $(window).load()s, in at least one case, the $(document).ready() replacement isn't working.

@laurelfulford
Copy link
Contributor Author

On second thought, I'm going to go ahead with this fix -- it addresses the hidden content. We can circle back on other things that don't work exactly right -- like the images being outset -- as needed.

@laurelfulford laurelfulford merged commit 74babc0 into master May 3, 2018
@laurelfulford laurelfulford deleted the 108-illustratr-ads-js branch May 3, 2018 00:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant