Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kbd tag styling #901

Merged
merged 2 commits into from
Oct 16, 2018
Merged

Add kbd tag styling #901

merged 2 commits into from
Oct 16, 2018

Conversation

rakhi2104
Copy link
Contributor

Added styling to kbd to adopt GFM
Resolves #763

Result:
screenshot from 2018-10-11 00-40-54

@mirka mirka self-requested a review October 10, 2018 22:14
@mirka mirka added this to the 1.2.1 milestone Oct 10, 2018
@mirka
Copy link
Member

mirka commented Oct 11, 2018

Beautiful! We'll also need to add kbd to the whitelist in sanitize-html.js, right? It won't render for me unless I do that.

@rakhi2104
Copy link
Contributor Author

Hmm... 🤔
But it did work on mine 😅

@rakhi2104
Copy link
Contributor Author

  • Corrected 'kbd' tag styles to adjust to text zoom.
  • Added 'kbd' tag in sanitize-html.js

mirka
mirka approved these changes Oct 12, 2018
View reviewed changes
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rakhi2104 ! Nice tweak re: text zoom 👏You can also do something like font-size: .75em to keep it at a 12/16px ratio while zooming — would that be closer to your original intent?

@mirka mirka merged commit 4f78140 into Automattic:master Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirka mirka mirka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rakhi2104 @mirka