Add ajv package (peer dependency of webpack) #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roundhill
reviewed
Aug 29, 2018
package.json
Outdated
| @@ -42,6 +42,7 @@ | |||
| "trailingComma": "es5" | |||
| }, | |||
| "devDependencies": { | |||
| "ajv": "^6.5.3", | |||
There was a problem hiding this comment.
Should we pin the exact version instead of adding the wildcard? I think that's the recommended way to do it so we don't get unexpected results.
There was a problem hiding this comment.
Thanks for bringing this up. I was a little unclear about the current package-lock behavior, but after reading up about it I agree that we should pin exact versions here. Will fix.
There was a problem hiding this comment.
Another link that helped me understand the confusion around this. The behavior around npm install and package-lock changed between minor versions of npm5 😓
|
😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ajv package (required by
ajv-keywordsrequired bywebpack) was missing, resulting in a peer dependency warning.This fix adds the missing package to our devDependencies.