Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new note button separator color in focus mode #2998

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Fix new note button separator color in focus mode #2998

merged 1 commit into from
Sep 17, 2021

Conversation

sandymcfadden
Copy link
Contributor

Fix

The color of the separator line between the new note button and focus mode button, while in focus mode, was not being set correctly. This ensures it is set to the right color

Before
Screen Shot 2021-09-10 at 9 53 11 AM
Screen Shot 2021-09-10 at 9 53 28 AM

After
Screen Shot 2021-09-10 at 9 53 51 AM
Screen Shot 2021-09-10 at 9 53 39 AM

Test

  • Smoke test in light and dark mode
  • Switch to focus mode
  • Ensure the separator color matches other border colors

Release

  • Fixed the new note button separator color while in focus mode

@sandymcfadden sandymcfadden added this to the 2.20.0 milestone Sep 10, 2021
@sandymcfadden sandymcfadden self-assigned this Sep 10, 2021
@SylvesterWilmott
Copy link
Contributor

Thanks for the quick turnaround on this one. Looks good!

rj-xy
rj-xy approved these changes Sep 15, 2021
View reviewed changes
Copy link

@rj-xy rj-xy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

codebykat
codebykat approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@codebykat codebykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sandymcfadden sandymcfadden merged commit 4eaf340 into develop Sep 17, 2021
@sandymcfadden sandymcfadden deleted the fix/focus-mode-new-note-separator-color branch September 17, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebykat codebykat codebykat approved these changes

@rj-xy rj-xy rj-xy approved these changes

@SylvesterWilmott SylvesterWilmott SylvesterWilmott approved these changes

@belcherj belcherj Awaiting requested review from belcherj

Assignees

@sandymcfadden sandymcfadden

Labels
None yet
Projects
None yet
Milestone
2.20.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sandymcfadden @SylvesterWilmott @codebykat @rj-xy