Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/hide clear search button #2862

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Fix/hide clear search button #2862

merged 2 commits into from
Apr 28, 2021

Conversation

sandymcfadden
Copy link
Contributor

Fix

Fixes #2860

Currently, the X icon in the search field, used to clear the search term, is always present. It should only show when there is a search term to clear. This fixes that.

Before:
Screen Shot 2021-04-20 at 10 54 48 AM

After:
Screen Shot 2021-04-20 at 10 54 32 AM

Test

  1. Open Simplenote.
  2. Ensure X icon does not show in search field.
  3. Add a search term.
  4. Ensure X icon does now appear.
  5. Click the X icon
  6. Ensure the search term is removed.

Release

NA

@sandymcfadden sandymcfadden added this to the 2.10.0 milestone Apr 20, 2021
@sandymcfadden sandymcfadden requested a review from a team April 20, 2021 13:56
@sandymcfadden sandymcfadden self-assigned this Apr 20, 2021
@belcherj
Copy link
Contributor

Hmm, looks like there are other commits in here. Was that intended?

@belcherj
Copy link
Contributor

Tested and change works. Let me know when the commit issue is worked out and I will approve.

@sandymcfadden sandymcfadden force-pushed the fix/hide-clear-search-button branch from 9a5ea0c to d1aa489 Compare April 20, 2021 16:40
@sandymcfadden
Copy link
Contributor Author

Hmm, looks like there are other commits in here. Was that intended?

Thanks so much @belcherj for catching this.
I've fixed it up now.

belcherj
belcherj approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@belcherj belcherj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

@sandymcfadden sandymcfadden force-pushed the fix/hide-clear-search-button branch from d1aa489 to 47defc5 Compare April 28, 2021 11:36
@sandymcfadden sandymcfadden merged commit a7becbc into release/2.10.0 Apr 28, 2021
@sandymcfadden sandymcfadden deleted the fix/hide-clear-search-button branch April 28, 2021 11:55
sandymcfadden added a commit that referenced this pull request Apr 28, 2021
@sandymcfadden
Fix/hide clear search button (#2862)
536890f 
Fixes #2860

Currently, the X icon in the search field, used to clear the search term, is always present. It should only show when there is a search term to clear. This fixes that.
@sandymcfadden sandymcfadden mentioned this pull request Apr 28, 2021
Merged
sandymcfadden added a commit that referenced this pull request Apr 28, 2021
@sandymcfadden
Merge 2.10.0 beta 2 into develop (#2877)
1a88417 
There were a few hotfixes which went into 2.10.0 beta 2, this moves them back into develop.
See: #2867, #2863, #2862, and #2876.
@sandymcfadden sandymcfadden mentioned this pull request May 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belcherj belcherj belcherj approved these changes

Assignees

@sandymcfadden sandymcfadden

Labels
None yet
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sandymcfadden @belcherj