-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the revision slider so that it does not cover the bottom of long notes #2662
Update the revision slider so that it does not cover the bottom of long notes #2662
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think this should also be a hotfix against release/2.7.0. I'll leave the rebase to you for practice :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh also when you rebase against release/2.7.0 don't forget to add a line to the release notes :) (Just setting as Changes Requested to make sure you see this)
4add524
to
3648559
Compare
@codebykat you were right about me needing the practice. It looks like I still need more and that I messed this up again. |
3648559
to
0daf99f
Compare
Thanks so much, @belcherj for helping me get this PR fixed up with the git lesson. |
Yeah, fair. So what I would do is edit the release notes to add a link to this PR as well. You can see prior examples where we had more than one PR linked for a single line. Nice work on the git fix! I love that JB and I have totally different methods of resolving that issue. Git: There is always more than one correct way to shoot yourself in the foot. 😂 |
Thank you @codebykat! I've updated the release notes now. |
Thanks @codebykat 🙌 ! |
Fix
With the update to the slider position, it was sitting over top the bottom of long notes. So you couldn't see changes happening at the end no matter how far you scrolled.
This also fixes a problem with the position of the date above the slider.
This resolves #2655
Test
Release